Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1770683002: Revert "about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg" (Closed)

Created:
4 years, 9 months ago by kjellander_chromium
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg" Reason: This breaks WebRTC standalone from rolling chromium_revision in the DEPS file. See https://codereview.webrtc.org/1765393002/ for examples. The problem is that the Chromium build/common.gypi gets a hardcoded dependency into ../third_party/webrtc/build/common.gypi, which doesn't resolve when a standalone WebRTC checkout tries to process Chromium's build/common.gypi. For reland: Please move the rtc_use_h264 variable into Chromium's GYP chain if it needs to be accessed from this context. This reverts commit 8018fbdf7bd32858d8926772e54c9ee20227d403. > about_flags.cc entry for WebRTC-H264WithOpenH264FFmpeg > (base::Feature kWebRtcH264WithOpenH264FFmpeg). > This is a feature that enables a H.264 encoder/decoder in > WebRTC. The feature is off by default. > BUG=chromium:500605, chromium:468365 > Committed: https://crrev.com/8018fbdf7bd32858d8926772e54c9ee20227d403 > Cr-Commit-Position: refs/heads/master@{#379284} TBR=hbos@chromium.org, jochen@chromium.org, flackr@chromium.org, asvitkine@chromium.org, rkaplow@chromium.org, BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/42c375980c81f9613eb5db60f135d845061c9b74 Cr-Commit-Position: refs/heads/master@{#379488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +1 line, -10 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kjellander_chromium
4 years, 9 months ago (2016-03-06 09:44:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770683002/1
4 years, 9 months ago (2016-03-06 09:46:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/153437)
4 years, 9 months ago (2016-03-06 10:20:27 UTC) #10
kjellander_chromium
On 2016/03/06 10:20:27, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-06 10:29:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770683002/1
4 years, 9 months ago (2016-03-06 10:29:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-06 11:44:34 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-06 11:46:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42c375980c81f9613eb5db60f135d845061c9b74
Cr-Commit-Position: refs/heads/master@{#379488}

Powered by Google App Engine
This is Rietveld 408576698