Add fuzzer test for various media parsers

Add fuzzer test for various media parsers

These fuzzer tests basically follow what is done in the corresponding
unit test. They just go as far as they can with the data provided.

TEST=new fuzzer tests run

Committed: https://crrev.com/8d9c9e6abeb092dd85f19bdc56add56ec3c16d42
Cr-Commit-Position: refs/heads/master@{#379897}

[jrummell, 2016-03-05 01:21:53]

jrummell@chromium.org changed reviewers:
+ dalecurtis@chromium.org, kcc@chromium.org

[jrummell, 2016-03-05 01:21:54]

PTAL. Last set of media fuzzer tests.

[DaleCurtis, 2016-03-05 01:30:06]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org

[DaleCurtis, 2016-03-05 01:30:06]

+sandersd in case he has suggestions.

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
File media/filters/h264_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
media/filters/h264_parser_fuzzertest.cc:12: if (size > 0) {
Invert conditional, return 0 if !size.

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
media/filters/h264_parser_fuzzertest.cc:29: } break;
put break in the {} block.

https://codereview.chromium.org/1770583002/diff/1/media/filters/vp8_parser_fu...
File media/filters/vp8_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/1/media/filters/vp8_parser_fu...
media/filters/vp8_parser_fuzzertest.cc:21: if (ivf_file_header.fourcc !=
0x30385056u)  // VP80
Does this trigger a dcheck otherwise? Seems you could combine the vp8/vp9 fuzzer
tests by conditionally going down one path or the other. Dunno if fuzzer team
would prefer them separate.

[sandersd (OOO until July 31), 2016-03-05 01:56:34]

> +sandersd in case he has suggestions.

Nothing additional from me, that covers most of H.264.

The one thing I would like to add is testing of H264POC, but it starts to
require very specific things of the H.264 stream to get any coverage. I doubt
we'd get much value without a custom setup for that, but I could be wrong. We
could just feed it whenever we have a parsed SPS and a slice header and see what
happens.

[jrummell, 2016-03-07 20:07:27]

jrummell@chromium.org changed reviewers:
+ aizatsky@chromium.org, mmoroz@chromium.org

[jrummell, 2016-03-07 20:07:28]

Updated.

+mmoroz@ and aizatsky@ in case they have any comments.

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
File media/filters/h264_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
media/filters/h264_parser_fuzzertest.cc:12: if (size > 0) {
On 2016/03/05 01:30:06, DaleCurtis wrote:
> Invert conditional, return 0 if !size.

Done.

https://codereview.chromium.org/1770583002/diff/1/media/filters/h264_parser_f...
media/filters/h264_parser_fuzzertest.cc:29: } break;
On 2016/03/05 01:30:06, DaleCurtis wrote:
> put break in the {} block. 

Done.

https://codereview.chromium.org/1770583002/diff/1/media/filters/vp8_parser_fu...
File media/filters/vp8_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/1/media/filters/vp8_parser_fu...
media/filters/vp8_parser_fuzzertest.cc:21: if (ivf_file_header.fourcc !=
0x30385056u)  // VP80
On 2016/03/05 01:30:06, DaleCurtis wrote:
> Does this trigger a dcheck otherwise? Seems you could combine the vp8/vp9
fuzzer
> tests by conditionally going down one path or the other. Dunno if fuzzer team
> would prefer them separate.

Since we're testing with random files, I removed this check so that it still
attempts to parse it.

Doesn't matter to me if we combine the vp8 and vp9 tests. Just figured this way
the tests line up with the class they are testing. I would put both vp8 and vp9
files in the seed directories.

[aizatsky, 2016-03-07 21:17:53]

lgtm

[DaleCurtis, 2016-03-07 21:40:17]

lgtm % up to you nit.

https://codereview.chromium.org/1770583002/diff/20001/media/filters/h264_pars...
File media/filters/h264_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/20001/media/filters/h264_pars...
media/filters/h264_parser_fuzzertest.cc:20: while (true) {
could do {} while (res = ok) and move res outside of the loop.

[jrummell, 2016-03-08 01:37:43]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:38:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770583002/20001

[jrummell, 2016-03-08 01:38:45]

Thanks for the reviews.

https://codereview.chromium.org/1770583002/diff/20001/media/filters/h264_pars...
File media/filters/h264_parser_fuzzertest.cc (right):

https://codereview.chromium.org/1770583002/diff/20001/media/filters/h264_pars...
media/filters/h264_parser_fuzzertest.cc:20: while (true) {
On 2016/03/07 21:40:17, DaleCurtis wrote:
> could do {} while (res = ok) and move res outside of the loop.

I considered it, but there are 2 checks for != kOk.

[commit-bot: I haz the power, 2016-03-08 01:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:53:47]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmoroz, 2016-03-08 10:57:07]

LGTM

[jrummell, 2016-03-08 19:28:38]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-03-08 19:28:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org,
aizatsky@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1770583002/#ps40001
(title: "add base dependency")

[commit-bot: I haz the power, 2016-03-08 19:29:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770583002/40001

[commit-bot: I haz the power, 2016-03-08 20:13:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 20:15:32]

Description was changed from

==========
Add fuzzer test for various media parsers

These fuzzer tests basically follow what is done in the corresponding
unit test. They just go as far as they can with the data provided.

TEST=new fuzzer tests run
==========

to

==========
Add fuzzer test for various media parsers

These fuzzer tests basically follow what is done in the corresponding
unit test. They just go as far as they can with the data provided.

TEST=new fuzzer tests run

Committed: https://crrev.com/8d9c9e6abeb092dd85f19bdc56add56ec3c16d42
Cr-Commit-Position: refs/heads/master@{#379897}
==========

[commit-bot: I haz the power, 2016-03-08 20:15:33]

Patchset 3 (id:??) landed as
https://crrev.com/8d9c9e6abeb092dd85f19bdc56add56ec3c16d42
Cr-Commit-Position: refs/heads/master@{#379897}