Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1770573002: Update extension buttons to Material Design (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md_toolbar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update extension buttons to Material Design (Mac). BUG=592172 Committed: https://crrev.com/554dd1c38b1c0ab60ff51189efce72774003a2e8 Cr-Commit-Position: refs/heads/master@{#379944}

Patch Set 1 #

Patch Set 2 : Code clean-up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -133 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 3 chunks +27 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm View 1 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm View 1 4 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h View 1 1 chunk +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 1 8 chunks +90 lines, -72 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 6 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/ui/layout_constants.cc View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
shrike
PTAL: sky@ for small change to chrome/browser/ui/layout_constants.cc avi@ for everything else
4 years, 9 months ago (2016-03-08 20:21:33 UTC) #2
Avi (use Gerrit)
👍
4 years, 9 months ago (2016-03-08 20:28:53 UTC) #3
Avi (use Gerrit)
On 2016/03/08 20:28:53, Avi wrote: > 👍 LGTM
4 years, 9 months ago (2016-03-08 20:29:00 UTC) #4
Lei Zhang
chrome/browser/ui/layout_constants.cc lgtm
4 years, 9 months ago (2016-03-08 21:40:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770573002/20001
4 years, 9 months ago (2016-03-08 21:46:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 22:34:16 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:35:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/554dd1c38b1c0ab60ff51189efce72774003a2e8
Cr-Commit-Position: refs/heads/master@{#379944}

Powered by Google App Engine
This is Rietveld 408576698