Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 177053005: DM: don't crash on Mac. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

DM: don't crash on Mac. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dm/DMReporter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein_C
One of the benchmarks must have a name with a '%' in it.
6 years, 9 months ago (2014-02-28 18:37:36 UTC) #1
mtklein_C
On 2014/02/28 18:37:36, mtklein_C wrote: > One of the benchmarks must have a name with ...
6 years, 9 months ago (2014-02-28 18:38:30 UTC) #2
reed1
lgtm
6 years, 9 months ago (2014-02-28 19:22:31 UTC) #3
bsalomon
On 2014/02/28 18:38:30, mtklein_C wrote: > On 2014/02/28 18:37:36, mtklein_C wrote: > > One of ...
6 years, 9 months ago (2014-02-28 19:28:06 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-02-28 19:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/177053005/1
6 years, 9 months ago (2014-02-28 19:38:20 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 20:29:01 UTC) #7
Message was sent while issue was closed.
Change committed as 13631

Powered by Google App Engine
This is Rietveld 408576698