Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 177053003: Enable use_allocator instead of linux_use_tcmalloc in Blink. (Closed)

Created:
6 years, 10 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
6 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, Mads Ager (chromium), yurys+blink_chromium.org, abarth-chromium, adamk+blink_chromium.org, Mikhail, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable use_allocator instead of linux_use_tcmalloc in Blink. See the bug and http://crrev.com/255129 for the details. BUG=345554 R=haraken@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168591

Patch Set 1 #

Patch Set 2 : update to use use_allocator #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/heap/blink_heap_tests.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/blink_platform_tests.gyp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/web_tests.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/wtf/wtf_tests.gyp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi OWNERS of some Blink gyp files, Could you take a look at these gyp ...
6 years, 9 months ago (2014-03-01 00:09:19 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-01 00:13:44 UTC) #2
jamesr
On 2014/03/01 00:13:44, jamesr wrote: > lgtm I think I can cover everything but /heap/. ...
6 years, 9 months ago (2014-03-01 00:14:04 UTC) #3
haraken
LGTM for heap/.
6 years, 9 months ago (2014-03-01 01:26:41 UTC) #4
Dai Mikurube (NOT FULLTIME)
Thanks, guys. http://crrev.com/255129 is now landed. Committing this change...
6 years, 9 months ago (2014-03-05 22:12:09 UTC) #5
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 9 months ago (2014-03-05 22:28:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/177053003/50001
6 years, 9 months ago (2014-03-05 22:28:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 23:49:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-05 23:49:34 UTC) #9
Dai Mikurube (NOT FULLTIME)
The CQ bit was checked by dmikurube@chromium.org
6 years, 9 months ago (2014-03-05 23:50:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/177053003/50001
6 years, 9 months ago (2014-03-05 23:54:50 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:34:31 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-06 01:34:32 UTC) #13
Dai Mikurube (NOT FULLTIME)
Committed patchset #5 manually as r168591 (presubmit successful).
6 years, 9 months ago (2014-03-06 08:04:06 UTC) #14
ErvinGottfried
6 years, 8 months ago (2014-04-05 06:51:57 UTC) #15
Message was sent while issue was closed.
On 2014/03/06 08:04:06, Dai Mikurube wrote:
> Committed patchset #5 manually as r168591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698