Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 177051: Add some logging in convert_dict (Closed)

Created:
11 years, 3 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
brettw, Hironori Bono
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add some logging in convert_dict. Currently, there is no way to tell what is failing, it is returning silently. This will output some information regarding what error occurred. BUG=20754 (http://crbug.com/20754) TEST=Compile and run convert_dict with korean dictionary (1 error will spit out which will help the converter whats wrong) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25444

Patch Set 1 #

Patch Set 2 : Fixing it up #

Total comments: 1

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/tools/convert_dict/convert_dict.cc View 1 2 1 chunk +17 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mohamed Mansour
11 years, 3 months ago (2009-09-01 03:14:44 UTC) #1
brettw
LGTM with minor style fix http://codereview.chromium.org/177051/diff/1001/1002 File chrome/tools/convert_dict/convert_dict.cc (right): http://codereview.chromium.org/177051/diff/1001/1002#newcode67 Line 67: return false; // ...
11 years, 3 months ago (2009-09-01 04:31:08 UTC) #2
Mohamed Mansour
I changed the logging to spit out the word instead of the index, as hbono ...
11 years, 3 months ago (2009-09-04 03:12:22 UTC) #3
Hironori Bono
11 years, 3 months ago (2009-09-04 06:06:32 UTC) #4
LGTM with a nit.
Thank you for your work.

http://codereview.chromium.org/177051/diff/4001/5001
File src/chrome/tools/convert_dict/convert_dict.cc (right):

http://codereview.chromium.org/177051/diff/4001/5001#newcode52
Line 52: if (org_words[i].first. != buf) {
nit: "org_words[i].first." -> "org_words[i].first"?

Powered by Google App Engine
This is Rietveld 408576698