Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1770493002: Remove MOJO_STATIC_CONST_MEMBER_DEFINITION. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -56 lines) Patch
M mojo/edk/system/channel_endpoint_id.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/system/macros.h View 1 chunk +0 lines, -23 lines 0 comments Download
M mojo/public/cpp/system/tests/macros_unittest.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-04 21:25:32 UTC) #1
jamesr
lgtm
4 years, 9 months ago (2016-03-04 21:28:19 UTC) #2
viettrungluu
4 years, 9 months ago (2016-03-04 21:33:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80b15e2cdd74d185cc185536baf378bf189f6fe9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698