Issue 1770473002: Try again to suppress mac deprecation warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1770473002: Try again to suppress mac deprecation warnings. (Closed)

Created:
4 years, 9 months ago by Tom Sepez

Modified:
4 years, 9 months ago

Reviewers:
Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	xfa.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Oliver Chang

lgtm, I'm not sure what's happening here, but maybe a 'defines!': [ 'V8_DEPRECATION_WARNINGS', ], might ...

4 years, 9 months ago (2016-03-04 20:16:48 UTC) #3

Oliver Chang

On 2016/03/04 20:16:48, Oliver Chang wrote: > lgtm, I'm not sure what's happening here, but ...

4 years, 9 months ago (2016-03-04 20:17:54 UTC) #4

Tom Sepez

4 years, 9 months ago (2016-03-04 20:19:44 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dca24838ce9799bd878477f36014525c9d6b645d (presubmit successful).