Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 177043009: Remove removed (and outdated anyway) Perl IDL compiler line from sed script (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
Scott Byer
CC:
chromium-reviews
Visibility:
Public.

Description

Remove removed (and outdated anyway) Perl IDL compiler line from sed script We've just switch to the Python IDL compiler in Blink r167983 https://src.chromium.org/viewvc/blink?view=rev&revision=167983 We can thus remove the Perl line from the Windows build sed script. (It's out of date anyway, following a renaming, so it's a nop.) TBR=scottbyer@chromium.org NOTRY=true BUG=239771 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/sanitize-win-build-log.sed View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Hi Scott, just a lil' cleanup.
6 years, 10 months ago (2014-02-27 09:19:18 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-27 09:19:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/177043009/1
6 years, 10 months ago (2014-02-27 09:19:37 UTC) #3
commit-bot: I haz the power
Change committed as 253823
6 years, 9 months ago (2014-02-27 15:00:46 UTC) #4
Scott Byer
6 years, 9 months ago (2014-02-27 18:59:12 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698