Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 17704003: Create RootWindowTransformer after root window's bounds and scale factor are updated. (Closed)

Created:
7 years, 6 months ago by oshima
Modified:
7 years, 5 months ago
Reviewers:
James Cook, Jun Mukai
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Create RootWindowTransformer after root window's bounds and scale factor are updated. Added SupportsHostWindowResize and updated tests that fails on win8. BUG=253690 TEST=covered by test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209000

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M ash/display/display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/root_window_transformers.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 10 chunks +30 lines, -0 lines 0 comments Download
ash/wm/panels/panel_window_resizer_unittest.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
7 years, 6 months ago (2013-06-25 19:15:45 UTC) #1
Jun Mukai
lgtm
7 years, 6 months ago (2013-06-25 21:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/17704003/1
7 years, 6 months ago (2013-06-25 21:52:12 UTC) #3
oshima
I had to skip several tests on win8. jamecook -> ash/test, ash/wm/
7 years, 6 months ago (2013-06-27 00:10:37 UTC) #4
James Cook
On 2013/06/27 00:10:37, oshima wrote: > I had to skip several tests on win8. > ...
7 years, 5 months ago (2013-06-27 14:55:42 UTC) #5
oshima
On 2013/06/27 14:55:42, James Cook (Chromium) wrote: > On 2013/06/27 00:10:37, oshima wrote: > > ...
7 years, 5 months ago (2013-06-27 16:43:52 UTC) #6
James Cook
LGTM
7 years, 5 months ago (2013-06-27 17:01:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/17704003/35001
7 years, 5 months ago (2013-06-27 17:08:47 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 20:58:23 UTC) #9
Message was sent while issue was closed.
Change committed as 209000

Powered by Google App Engine
This is Rietveld 408576698