Issue 17704002: Move image_decoder.cc/.h from webkit\glue to content\child.

Issue 17704002: Move image_decoder.cc/.h from webkit\glue to content\child. (Closed)

Created:
7 years, 6 months ago by ananta

Modified:
7 years, 5 months ago

Reviewers:
jamesr, jam

CC:
chromium-reviews, extensions-reviews_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move image_decoder.cc/.h from webkit\glue to content\child. This also brings in a new content API DecodeImage which is declared in content\public\child\image_decoder_utils.h. Used by chrome\browser code which runs mostly in the utilty process to decode icons. We still have issues with single process mode which results in chrome\browser depending on content_child. This will be addressed in a subsequent change. This is continuation of the ongoing work for bug https://code.google.com/p/chromium/issues/detail?can=2&q=237249 which is to split chrome.dll into a browser and a renderer/child component due to build issues on Windows. To achieve this we need to ensure that the browser code does not depend on webkit. This mostly comes through webkit\glue. BUG=237249 R=jam@chromium.org, jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208736

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -129 lines)			Patch
M	chrome/browser/DEPS	View	1 2 3	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_util.cc	View	1 2	3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/icon_loader_linux.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/DEPS	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/manifest_handlers/icons_handler.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/unpacker.cc	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/utility/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/utility/chrome_content_utility_client.cc	View	1 2	3 chunks	+5 lines, -4 lines	0 comments	Download
M	content/child/DEPS	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	content/child/image_decoder.h	View		3 chunks	+4 lines, -5 lines	0 comments	Download
A +	content/child/image_decoder.cc	View		3 chunks	+12 lines, -4 lines	0 comments	Download
M	content/content_child.gypi	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
A	content/public/child/image_decoder_utils.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	content/renderer/fetchers/image_resource_fetcher.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/image_loading_helper.cc	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
D	webkit/glue/image_decoder.h	View	1 2	1 chunk	+0 lines, -45 lines	0 comments	Download
D	webkit/glue/image_decoder.cc	View	1 2	1 chunk	+0 lines, -44 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

jam

https://codereview.chromium.org/17704002/diff/9002/chrome/browser/DEPS File chrome/browser/DEPS (right): https://codereview.chromium.org/17704002/diff/9002/chrome/browser/DEPS#newcode22 chrome/browser/DEPS:22: "+content/public/child/image_decoder_utils.h", this should replace line 70 to make it ...

7 years, 6 months ago (2013-06-25 23:24:32 UTC) #3

jam

btw i'm working on making utility process code run natively in single process mode

7 years, 6 months ago (2013-06-25 23:24:48 UTC) #4

ananta

https://codereview.chromium.org/17704002/diff/9002/chrome/common/DEPS File chrome/common/DEPS (right): https://codereview.chromium.org/17704002/diff/9002/chrome/common/DEPS#newcode27 chrome/common/DEPS:27: "+content/public/child/image_decoder_utils.h", On 2013/06/25 23:24:32, jam wrote: > ditto, make ...

7 years, 6 months ago (2013-06-25 23:35:28 UTC) #5

ananta

7 years, 5 months ago (2013-06-26 18:21:16 UTC) #8

Message was sent while issue was closed.

Committed patchset #4 manually as r208736 (presubmit successful).

Expand Messages | Collapse Messages