Chromium Code Reviews Chromium Code Reviews
Issue 1770383005:
Reduce indentation levels for sheriff docs. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/perf/docs/perf_bot_sheriffing.md |
| diff --git a/tools/perf/docs/perf_bot_sheriffing.md b/tools/perf/docs/perf_bot_sheriffing.md |
| index 6b072b8f563c35225792aa526c29b02ae888e4f2..8d7525e58402c8e54609fe2af49a5ea948e38cde 100644 |
| --- a/tools/perf/docs/perf_bot_sheriffing.md |
| +++ b/tools/perf/docs/perf_bot_sheriffing.md |
| @@ -5,17 +5,11 @@ waterfall up and running, and triaging performance test failures and flakes. |
| ## Key Responsibilities |
| - * [Keeping the chromium.perf waterfall green](#chromiumperf) |
| - * [Handling Test Failures](#testfailures) |
| - * [Handling Device and Bot Failures](#botfailures) |
| - * [Follow up on failures](#followup) |
| + * [Handle Test Failures](#testfailures) |
| + * [Handle Device and Bot Failures](#botfailures) |
|
aiolos (Not reviewing)
2016/03/09 17:57:38
Can you move the Device and Bot Failures before th
dtu
2016/03/09 22:27:44
Done.
|
| + * [Follow up on failures](#followup) |
| -###<a name="chromiumperf"></a> Keeping the chromium.perf waterfall green |
| - |
| -The primary responsibility of the perfbot health sheriff is to keep the |
| -chromium.perf waterfall green. |
| - |
| -####<a name="waterfallstate"></a> Understanding the Waterfall State |
| +##<a name="waterfallstate"></a> Understanding the Waterfall State |
| Everyone can view the chromium.perf waterfall at |
| https://build.chromium.org/p/chromium.perf/, but for Googlers it is recommended |
| @@ -44,20 +38,20 @@ Note that there are four different views: |
| * **start_time** is seconds since the epoch. |
| You can see a list of all previously filed bugs using the |
| -**[Performance-BotHealth](https://code.google.com/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth)** |
| +**[Performance-BotHealth](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth)** |
| label in crbug. |
| Please also check the recent |
| **[perf-sheriffs@chromium.org](https://groups.google.com/a/chromium.org/forum/#!forum/perf-sheriffs)** |
| postings for important announcements about bot turndowns and other known issues. |
| -####<a name="testfailures"></a> Handling Test Failures |
| +##<a name="testfailures"></a> Handle Test Failures |
| You want to keep the waterfall green! So any bot that is red or purple needs to |
| be investigated. When a test fails: |
| 1. File a bug using |
| - [this template](https://code.google.com/p/chromium/issues/entry?labels=Performance-BotHealth,Pri-1,Type-Bug-Regression,OS-?&comment=Revision+range+first+seen:%0ALink+to+failing+step+log:%0A%0A%0AIf%20the%20test%20is%20disabled,%20please%20downgrade%20to%20Pri-2.&summary=%3Ctest%3E+failure+on+chromium.perf+at+%3Crevisionrange%3E). |
| + [this template](https://bugs.chromium.org/p/chromium/issues/entry?labels=Performance-BotHealth,Pri-1,Type-Bug-Regression,OS-?&comment=Revision+range+first+seen:%0ALink+to+failing+step+log:%0A%0A%0AIf%20the%20test%20is%20disabled,%20please%20downgrade%20to%20Pri-2.&summary=%3Ctest%3E+failure+on+chromium.perf+at+%3Crevisionrange%3E). |
| You'll want to be sure to include: |
| * Link to buildbot status page of failing build. |
| * Copy and paste of relevant failure snippet from the stdio. |
| @@ -92,10 +86,10 @@ be investigated. When a test fails: |
| the tab did not crash. |
| -#####<a name="telemetryfailures"></a> Disabling Telemetry Tests |
| +###<a name="telemetryfailures"></a> Disabling Telemetry Tests |
| If the test is a telemetry test, its name will have a '.' in it, such as |
| -thread_times.key_mobile_sites, or page_cycler.top_10. The part before the first |
| +thread\_times.key\_mobile\_sites, or page\_cycler.top\_10. The part before the first |
|
sullivan
2016/03/09 14:38:25
We could also consider backticks instead of backsl
dtu
2016/03/09 22:27:44
Done.
|
| dot will be a python file in [tools/perf/benchmarks]( |
| https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/benchmarks/). |
| @@ -129,15 +123,15 @@ and example of disabling a benchmark which OOMs on svelte. |
| Disabling CLs can be TBR-ed to anyone in tools/perf/OWNERS, but please do **not** |
| submit with NOTRY=true. |
| -#####<a name="otherfailures"></a> Disabling Other Tests |
| +###<a name="otherfailures"></a> Disabling Other Tests |
| Non-telemetry tests are configured in [chromium.perf.json](https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.perf.json). |
| You can TBR any of the per-file OWNERS, but please do **not** submit with |
| NOTRY=true. |
| -####<a name="botfailures"></a> Handling Device and Bot Failures |
| +##<a name="botfailures"></a> Handle Device and Bot Failures |
| -#####<a name="purplebots"></a> Purple bots |
| +###<a name="purplebots"></a> Purple bots |
| When a bot goes purple, it's it's usually because of an infrastructure failure |
| outside of the tests. But you should first check the logs of a purple bot to |
| @@ -146,11 +140,11 @@ turn the bot purple, for example. |
| If the bot goes purple and you believe it's an infrastructure issue, file a bug |
| with |
| -[this template](https://code.google.com/p/chromium/issues/entry?labels=Pri-1,Performance-BotHealth,Infra-Troopers,OS-?&comment=Link+to+buildbot+status+page:&summary=Purple+Bot+on+chromium.perf), |
| +[this template](https://bugs.chromium.org/p/chromium/issues/entry?labels=Pri-1,Performance-BotHealth,Infra-Troopers,OS-?&comment=Link+to+buildbot+status+page:&summary=Purple+Bot+on+chromium.perf), |
| which will automatically add the bug to the trooper queue. Be sure to note |
| which step is failing, and paste any relevant info from the logs into the bug. |
| -#####<a name="devicefailures"></a> Android Device failures |
| +###<a name="devicefailures"></a> Android Device failures |
| There are two types of device failures: |
| @@ -164,7 +158,7 @@ There are two types of device failures: |
| with the same device affinity number are failing, it's probably a device |
| failure. |
| -For both types of failures, please file a bug with [this template](https://code.google.com/p/chromium/issues/entry?labels=Pri-1,Performance-BotHealth,Infra-Labs,OS-Android&comment=Link+to+buildbot+status+page:&summary=Device+offline+on+chromium.perf) |
| +For both types of failures, please file a bug with [this template](https://bugs.chromium.org/p/chromium/issues/entry?labels=Pri-1,Performance-BotHealth,Infra-Labs,OS-Android&comment=Link+to+buildbot+status+page:&summary=Device+offline+on+chromium.perf) |
| which will add an issue to the infra labs queue. |
| If you need help triaging, here are the common labels you should use: |
| @@ -189,20 +183,20 @@ If you need help triaging, here are the common labels you should use: |
| If you still need help, ask the speed infra chat, or escalate to sullivan@. |
| -####<a name="followup"></a> Follow up on failures |
| +##<a name="followup"></a> Follow up on failures |
| -**[Pri-0 bugs](https://code.google.com/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-0)** |
| +**[Pri-0 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-0)** |
| should have an owner or contact on speed infra team and be worked on as top |
| priority. Pri-0 generally implies an entire waterfall is down. |
| -**[Pri-1 bugs](https://code.google.com/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-1)** |
| +**[Pri-1 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-1)** |
| should be pinged daily, and checked to make sure someone is following up. Pri-1 |
| bugs are for a red test (not yet disabled), purple bot, or failing device. |
| -**[Pri-2 bugs](https://code.google.com/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-2)** |
| +**[Pri-2 bugs](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3APerformance-BotHealth+label%3APri-2)** |
| are for disabled tests. These should be pinged weekly, and work towards fixing |
| should be ongoing when the sheriff is not working on a Pri-1 issue. Here is the |
| -[list of Pri-2 bugs that have not been pinged in a week](https://code.google.com/p/chromium/issues/list?can=2&q=label:Performance-BotHealth%20label:Pri-2%20modified-before:today-7&sort=modified) |
| +[list of Pri-2 bugs that have not been pinged in a week](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label:Performance-BotHealth%20label:Pri-2%20modified-before:today-7&sort=modified) |
| <!-- Unresolved issues: |
| 1. Do perf sheriffs watch the bisect waterfall? |
