Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1770383005: Reduce indentation levels for sheriff docs. (Closed)

Created:
4 years, 9 months ago by dtu
Modified:
4 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce indentation levels for sheriff docs. Around the fourth indentation level, the headings start becoming hard to skim. Committed: https://crrev.com/348891ae44a1c3b0c64b2b5c1754a52a3b567e6e Cr-Commit-Position: refs/heads/master@{#380734}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Commentz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -80 lines) Patch
M tools/perf/docs/perf_bot_sheriffing.md View 1 4 chunks +70 lines, -76 lines 0 comments Download
M tools/perf/docs/perf_regression_sheriffing.md View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dtu
4 years, 9 months ago (2016-03-08 23:39:40 UTC) #2
sullivan
lgtm Thanks for the cleanup! I agree this is much better. https://codereview.chromium.org/1770383005/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): ...
4 years, 9 months ago (2016-03-09 14:38:25 UTC) #3
aiolos (Not reviewing)
lgtm https://codereview.chromium.org/1770383005/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/1770383005/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode9 tools/perf/docs/perf_bot_sheriffing.md:9: * [Handle Device and Bot Failures](#botfailures) Can you ...
4 years, 9 months ago (2016-03-09 17:57:39 UTC) #4
dtu
https://codereview.chromium.org/1770383005/diff/1/tools/perf/docs/perf_bot_sheriffing.md File tools/perf/docs/perf_bot_sheriffing.md (right): https://codereview.chromium.org/1770383005/diff/1/tools/perf/docs/perf_bot_sheriffing.md#newcode9 tools/perf/docs/perf_bot_sheriffing.md:9: * [Handle Device and Bot Failures](#botfailures) On 2016/03/09 at ...
4 years, 9 months ago (2016-03-09 22:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770383005/20001
4 years, 9 months ago (2016-03-09 22:28:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/115329)
4 years, 9 months ago (2016-03-09 23:08:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770383005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770383005/20001
4 years, 9 months ago (2016-03-11 18:06:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 21:20:21 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 21:21:26 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/348891ae44a1c3b0c64b2b5c1754a52a3b567e6e
Cr-Commit-Position: refs/heads/master@{#380734}

Powered by Google App Engine
This is Rietveld 408576698