Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Issue 1770383002: [wasm] Rename _WASMEXP_ object to Wasm. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
ahaas, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename _WASMEXP_ object to Wasm. R=ahaas@chromium.org,binji@chromium.org BUG= Committed: https://crrev.com/5c1c98e8295012bbf2cabbf2fcb18f2ac2a7848b Cr-Commit-Position: refs/heads/master@{#34587}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -119 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-575364.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 67 chunks +70 lines, -70 lines 0 comments Download
M test/mjsunit/wasm/embenchen/box2d.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/copy.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/corrections.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/fannkuch.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/fasta.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/lua_binarytrees.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/memops.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/primes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/embenchen/zlib.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 7 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/wasm/verify-function-basic-errors.js View 1 chunk +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/verify-function-simple.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/verify-module-basic-errors.js View 1 chunk +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/wasm-object-api.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
titzer
4 years, 9 months ago (2016-03-08 12:49:16 UTC) #1
ahaas
lgtm
4 years, 9 months ago (2016-03-08 13:47:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770383002/20001
4 years, 9 months ago (2016-03-08 14:45:31 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 14:47:04 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5c1c98e8295012bbf2cabbf2fcb18f2ac2a7848b Cr-Commit-Position: refs/heads/master@{#34587}
4 years, 9 months ago (2016-03-08 14:48:35 UTC) #7
Derek Schuff
On 2016/03/08 14:48:35, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 9 months ago (2016-03-08 16:46:57 UTC) #8
Derek Schuff
On 2016/03/08 14:48:35, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 9 months ago (2016-03-08 16:47:00 UTC) #9
titzer
4 years, 9 months ago (2016-03-08 16:57:50 UTC) #10
Message was sent while issue was closed.
On 2016/03/08 16:47:00, Derek Schuff wrote:
> On 2016/03/08 14:48:35, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/5c1c98e8295012bbf2cabbf2fcb18f2ac2a7848b
> > Cr-Commit-Position: refs/heads/master@{#34587}
> 
> So, one problem with landing this now is that now we have no way to determine
in
> the Binaryen code whether we need to flatten the imports object. Before You
> could check whether _WASMEXP_ or Wasm was an object. Is there some other way I
> can tell I'm in V8 instead of SM?

I'm in the middle of implementing the two-level imports so that should just go
away.

Powered by Google App Engine
This is Rietveld 408576698