[wasm] Use MachineOperatorBuilder::word() instead of kPointerSize to determine the word size.

[wasm] Use MachineOperatorBuilder::word() instead of kPointerSize to determine the word size.

R=titzer@chromium.org

Committed: https://crrev.com/4122df2615a8acc64a50dcc394667af6ee7c5ad2
Cr-Commit-Position: refs/heads/master@{#34581}

[titzer, 2016-03-08 08:06:15]

lgtm other than one simplification

https://codereview.chromium.org/1770333002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1770333002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:865: if (m->word() ==
MachineRepresentation::kWord32) {
You can use the Is32() predicate.

[ahaas, 2016-03-08 08:29:09]

https://codereview.chromium.org/1770333002/diff/1/src/compiler/wasm-compiler.cc
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/1770333002/diff/1/src/compiler/wasm-compiler....
src/compiler/wasm-compiler.cc:865: if (m->word() ==
MachineRepresentation::kWord32) {
On 2016/03/08 at 08:06:15, titzer wrote:
> You can use the Is32() predicate.

Ha, that makes the code much more beautiful!

[ahaas, 2016-03-08 11:28:40]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-03-08 11:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1770333002/#ps20001
(title: "Use Is32 instead of word() == MachineRepresentation::kWord32")

[commit-bot: I haz the power, 2016-03-08 11:28:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770333002/20001

[commit-bot: I haz the power, 2016-03-08 11:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 11:47:04]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14925)

[ahaas, 2016-03-08 12:39:40]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-03-08 12:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770333002/20001

[commit-bot: I haz the power, 2016-03-08 12:41:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-08 12:42:46]

Description was changed from

==========
[wasm] Use MachineOperatorBuilder::word() instead of kPointerSize to determine
the word size.

R=titzer@chromium.org
==========

to

==========
[wasm] Use MachineOperatorBuilder::word() instead of kPointerSize to determine
the word size.

R=titzer@chromium.org

Committed: https://crrev.com/4122df2615a8acc64a50dcc394667af6ee7c5ad2
Cr-Commit-Position: refs/heads/master@{#34581}
==========

[commit-bot: I haz the power, 2016-03-08 12:42:47]

Patchset 2 (id:??) landed as
https://crrev.com/4122df2615a8acc64a50dcc394667af6ee7c5ad2
Cr-Commit-Position: refs/heads/master@{#34581}