Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1770323003: Fix summary generation in "package-summary-only" mode. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix summary generation in "package-summary-only" mode. If we aren't doing full analysis, then we can't use `context.librarySources` to find out the set of library sources (because it doesn't include sources that haven't been examined yet). Instead, we have to query each source to find out its type. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c497c026fef3b48cd1c2649b15c1029d7fab793c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/analyzer_cli/lib/src/package_analyzer.dart View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-08 18:10:19 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-08 18:25:24 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-08 20:14:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c497c026fef3b48cd1c2649b15c1029d7fab793c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698