Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1770323002: Fix non-Oilpan following r379558. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
haraken, Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-Oilpan following r379558. R= BUG=580169 Committed: https://crrev.com/49a3f94e52b4b61c06d9ba759973412bb99d26b1 Cr-Commit-Position: refs/heads/master@{#379786}

Patch Set 1 #

Patch Set 2 : more PassRefPtr<> fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 4 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sof
please take a look. i'm not very happy about this.
4 years, 9 months ago (2016-03-08 07:08:22 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-03-08 07:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770323002/20001
4 years, 9 months ago (2016-03-08 07:32:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 08:23:32 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/49a3f94e52b4b61c06d9ba759973412bb99d26b1 Cr-Commit-Position: refs/heads/master@{#379786}
4 years, 9 months ago (2016-03-08 08:26:54 UTC) #10
Rick Byers
Thanks for the fix, sorry for not catching this in review. Maybe we should add ...
4 years, 9 months ago (2016-03-08 20:11:12 UTC) #11
sof
On 2016/03/08 20:11:12, Rick Byers wrote: > Thanks for the fix, sorry for not catching ...
4 years, 9 months ago (2016-03-08 21:38:22 UTC) #12
haraken
4 years, 9 months ago (2016-03-08 23:03:36 UTC) #13
Message was sent while issue was closed.
On 2016/03/08 20:11:12, Rick Byers wrote:
> Thanks for the fix, sorry for not catching this in review.  Maybe we should
add
> a single non-oilpan bot to the CQ?

We've tried that many times but couldn't (because of the amount of work on the
infra team).

Powered by Google App Engine
This is Rietveld 408576698