Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: factory/commands.py

Issue 177028: Detect perf regressions and speedups automatically.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: factory/commands.py
===================================================================
--- factory/commands.py (revision 24874)
+++ factory/commands.py (working copy)
@@ -331,7 +331,7 @@
# Performance step utils.
def _CreatePerformanceStepClass(
self, log_processor_class, report_link=None, output_dir=None,
- command_class=chromium_step.ProcessLogShellStep):
+ perf_name=None, command_class=chromium_step.ProcessLogShellStep):
"""Returns ProcessLogShellStep class.
Args:
@@ -352,7 +352,8 @@
# 2. Creates a unique log processor class for each individual step, so
# they can keep state that won't be shared between builds
log_processor_class = chromium_utils.InitializePartiallyWithArguments(
- log_processor_class, report_link=report_link, output_dir=output_dir)
+ log_processor_class, report_link=report_link, output_dir=output_dir,
+ perf_name=perf_name)
# Similarly, we need to allow buildbot to create the step itself without
# using additional parameters, so we create a step class that already
# knows which log_processor to use.
@@ -364,10 +365,12 @@
"""Selects the right build step for the specified perf test."""
report_link = None
output_dir = None
+ perf_name = None
if show_results and self._target in mappings:
mapping = mappings[self._target]
dir_name = mapping.get(perf_id)
if dir_name:
+ perf_name = dir_name
report_link = "%s/%s/%s" % (self.PERF_BASE_URL, dir_name,
self.PERF_REPORT_URL_SUFFIX)
output_dir = '%s/%s/' % (self.PERF_OUTPUT_DIR, dir_name)
@@ -377,4 +380,5 @@
return self._CreatePerformanceStepClass(log_processor_class,
report_link=report_link,
- output_dir=output_dir)
+ output_dir=output_dir,
+ perf_name=perf_name)

Powered by Google App Engine
This is Rietveld 408576698