Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chromium_step.py

Issue 177028: Detect perf regressions and speedups automatically.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/scripts/master/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | factory/chromium_commands.py » ('j') | log_parser/process_log.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromium_step.py
===================================================================
--- chromium_step.py (revision 24874)
+++ chromium_step.py (working copy)
@@ -124,6 +124,15 @@
text_list = text_list + self._result_text
return text_list
+ def evaluateCommand(self, cmd):
+ # If the log processor provides a facility to evaluate its performance,
+ # call it.
+ if self._log_processor and self._log_processor.evaluateCommand:
+ return self._log_processor.evaluateCommand(cmd)
+
+ # Otherwise, report success by default.
+ return builder.SUCCESS
+
def _CreateReportLinkIfNeccessary(self):
if self._log_processor.ReportLink():
self.addURL('results', "%s" % self._log_processor.ReportLink())
« no previous file with comments | « no previous file | factory/chromium_commands.py » ('j') | log_parser/process_log.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698