Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1770273002: Remove extraneous xfa/src/fwl/src include/ directories. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove extraneous xfa/src/fwl/src include/ directories. This CL collapses the xfa/src/fwl/src/core/include and xfa/src/fwl/src/basewidget/include up one level. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a44cbb591ec1fb60d6da907db63b69d0b7bd0c39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -3108 lines) Patch
M BUILD.gn View 1 chunk +25 lines, -25 lines 0 comments Download
M xfa.gyp View 1 chunk +25 lines, -25 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_picturebox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_scrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_content.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fwl/core/fwl_panel.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_barcodeimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_caretimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_checkboximp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_comboboximp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.h View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_editimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_formproxyimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_formproxyimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_listboximp.h View 3 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_pictureboximp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_scrollbarimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/basewidget/fxmath_barcodeimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fxmath_barcodeimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_barcodeimp.h View 1 chunk +0 lines, -54 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_caretimp.h View 1 chunk +0 lines, -67 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_checkboximp.h View 1 chunk +0 lines, -64 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h View 1 chunk +0 lines, -237 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 1 chunk +0 lines, -235 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 1 chunk +0 lines, -208 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_formproxyimp.h View 1 chunk +0 lines, -42 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_listboximp.h View 1 chunk +0 lines, -121 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 1 chunk +0 lines, -243 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_pictureboximp.h View 1 chunk +0 lines, -53 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_pushbuttonimp.h View 1 chunk +0 lines, -65 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_scrollbarimp.h View 1 chunk +0 lines, -139 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_spinbuttonimp.h View 1 chunk +0 lines, -69 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fwl_tooltipctrlimp.h View 1 chunk +0 lines, -86 lines 0 comments Download
D xfa/src/fwl/src/basewidget/include/fxmath_barcodeimp.h View 1 chunk +0 lines, -56 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_appimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_appimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_contentimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_formimp.h View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_gridimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_gridimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_noteimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_noteimp.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_panelimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_panelimp.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_sdadapterimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_targetimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_targetimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/src/fwl/src/core/fwl_threadimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_threadimp.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_timerimp.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_widgetimp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + xfa/src/fwl/src/core/fwl_widgetmgrimp.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_appimp.h View 1 chunk +0 lines, -38 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_contentimp.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_formimp.h View 1 chunk +0 lines, -193 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_gridimp.h View 1 chunk +0 lines, -197 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_noteimp.h View 1 chunk +0 lines, -157 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_panelimp.h View 1 chunk +0 lines, -32 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_targetimp.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_threadimp.h View 1 chunk +0 lines, -40 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_widgetimp.h View 1 chunk +0 lines, -162 lines 0 comments Download
D xfa/src/fwl/src/core/include/fwl_widgetmgrimp.h View 1 chunk +0 lines, -170 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-08 02:34:55 UTC) #2
Tom Sepez
LGTM based on the gyp/gn files, plus spot-checking a few of the #include changes.
4 years, 9 months ago (2016-03-08 03:40:03 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-08 13:51:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a44cbb591ec1fb60d6da907db63b69d0b7bd0c39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698