Devtools: resolve expressions in minified scripts with sourcemaps

Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092
Committed: https://crrev.com/b3075c07b6fc33a7efdf833eb42a39a5aa75d2a9
Cr-Commit-Position: refs/heads/master@{#380051}

[sergeyv, 2016-03-08 02:13:43]

sergeyv@chromium.org changed reviewers:
+ dgozman@chromium.org

[sergeyv, 2016-03-08 02:21:01]

Description was changed from

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=
==========

to

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092
==========

[dgozman, 2016-03-08 18:26:42]

lgtm

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:218:
var startIndex = mappings.lowerBound({lineNumber: lineNumber, columnNumber:
startColumnNumber}, comparator);
Let's move this to SourceMap.reverseMapTextRange.

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:259:
endIndex = token.end;
Let's not do this if current balance of [] is zero.

[sergeyv, 2016-03-08 22:53:04]

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
(right):

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:218:
var startIndex = mappings.lowerBound({lineNumber: lineNumber, columnNumber:
startColumnNumber}, comparator);
On 2016/03/08 18:26:42, dgozman wrote:
> Let's move this to SourceMap.reverseMapTextRange.

Done.

https://codereview.chromium.org/1770263002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js:259:
endIndex = token.end;
On 2016/03/08 18:26:42, dgozman wrote:
> Let's not do this if current balance of [] is zero.

Done.

[sergeyv, 2016-03-08 22:53:09]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2016-03-08 22:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1770263002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-03-08 22:53:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770263002/20001

[commit-bot: I haz the power, 2016-03-09 01:59:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 01:59:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sergeyv, 2016-03-09 02:00:26]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2016-03-09 02:00:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770263002/20001

[commit-bot: I haz the power, 2016-03-09 03:23:49]

Description was changed from

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092
==========

to

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092
==========

[commit-bot: I haz the power, 2016-03-09 03:23:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 03:25:10]

Description was changed from

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092
==========

to

==========
Devtools: resolve expressions in minified scripts with sourcemaps

BUG=327092

Committed: https://crrev.com/b3075c07b6fc33a7efdf833eb42a39a5aa75d2a9
Cr-Commit-Position: refs/heads/master@{#380051}
==========

[commit-bot: I haz the power, 2016-03-09 03:25:11]

Patchset 2 (id:??) landed as
https://crrev.com/b3075c07b6fc33a7efdf833eb42a39a5aa75d2a9
Cr-Commit-Position: refs/heads/master@{#380051}

[paulirish, 2016-03-09 18:07:06]

sergey, alexei: can you file a followup bug for the function names item we saw
yesterday