Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1770243002: Change line limit to 80 char. (Closed)

Created:
4 years, 9 months ago by azani
Modified:
4 years, 9 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change line limit to 80 char. And add a new strategy for printing method params to try to get under the 80 char limit. BUG= #592 R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05e4bc1e780d841c4a38055dba7623bfef53cf4a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/formatter/formatter_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M mojom/mojom_parser/formatter/printer.go View 1 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
azani
4 years, 9 months ago (2016-03-08 00:37:59 UTC) #2
rudominer
lgtm
4 years, 9 months ago (2016-03-08 00:38:57 UTC) #3
azani
4 years, 9 months ago (2016-03-08 01:02:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
05e4bc1e780d841c4a38055dba7623bfef53cf4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698