DescriptionRevert of Add base::TimeDelta::Max(). (https://codereview.chromium.org/163413004/)
Reason for revert:
The return value of kInfiniteDuration() is sometimes (flaky) serialized to JSON. JSON cannot support non-finite numbers.
3 tests crashed:
PipelineIntegrationTest.MediaSource_ConfigChange_MP4
PipelineIntegrationTest.MediaSource_MP3
PipelineIntegrationTest.MediaSource_MP3_Icecast
[10201:10201:0226/144332:2770747412:FATAL:values.cc(200)] Check failed: false. Non-finite (i.e. NaN or positive/negative infinity) values cannot be represented in JSON
Complete stack trace:
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@[10180:10180:0226/144324:2762555674:FATAL:values.cc(200)] Check failed: false. Non-finite (i.e. NaN or positive/negative infinity) values cannot be represented in JSON@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cf5d5d4] base::debug::StackTrace::StackTrace()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfcc109] logging::LogMessage::~LogMessage()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3d0c41df] base::FundamentalValue::FundamentalValue()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3d0c5528] base::DictionaryValue::SetDouble()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c74ad4f] media::MediaLog::CreateTimeEvent()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7537f2] media::Pipeline::SetDuration()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7c0070] media::ChunkDemuxer::UpdateDuration()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7bfa7a] media::ChunkDemuxer::OnSourceInitDone()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7ccabc] base::internal::RunnableAdapter\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7cb58b] base::internal::InvokeHelper\u003C>::MakeItSo()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7c92be] base::internal::Invoker\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c8aaba2] base::Callback\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c9085e4] media::mp4::MP4StreamParser::ParseMoov()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c9071d2] media::mp4::MP4StreamParser::ParseBox()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c906e9a] media::mp4::MP4StreamParser::Parse()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7b66f3] media::SourceState::Append()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3c7bd18f] media::ChunkDemuxer::AppendData()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007cf7b5] media::MockMediaSource::AppendData()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007cfeae] media::MockMediaSource::DemuxerOpenedTask()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007d497c] base::internal::RunnableAdapter\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007d4272] base::internal::InvokeHelper\u003C>::MakeItSo()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007d3a19] base::internal::Invoker\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cf48063] base::Callback\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfec6b8] base::MessageLoop::RunTask()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfec7dc] base::MessageLoop::DeferOrRunPendingTask()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfecd03] base::MessageLoop::DoWork()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cffb4bc] base::MessagePumpDefault::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfec207] base::MessageLoop::RunHandler()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3d050dc8] base::RunLoop::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3cfeb8fa] base::MessageLoop::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007d03d9] media::PipelineIntegrationTest::StartPipelineWithMediaSource()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000007c5f90] media::PipelineIntegrationTest_MediaSource_ConfigChange_MP4_Test::TestBody()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000954992] testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000950703] testing::internal::HandleExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000944d65] testing::Test::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000094538e] testing::TestInfo::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000009458e9] testing::TestCase::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000094a35b] testing::internal::UnitTestImpl::RunAllTests()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000955c37] testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000009515f7] testing::internal::HandleExceptionsInMethodIfSupported\u003C>()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000949349] testing::UnitTest::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x0000009144d1] RUN_ALL_TESTS()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000913eb4] base::TestSuite::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000063e8ca] base::internal::RunnableAdapter\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000063e84f] base::internal::InvokeHelper\u003C>::MakeItSo()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000063e7fb] base::internal::Invoker\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000090f1fb] base::Callback\u003C>::Run()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000090d2e2] base::(anonymous namespace)::LaunchUnitTestsInternal()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000090d5ae] base::LaunchUnitTests()@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x00000063e4f4] main@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x7f9c3b25776d] __libc_start_main@@@
@@@STEP_LOG_LINE@MediaSource_ConfigChange_MP4@ [0x000000484eb9] \u003Cunknown>@@@
Original issue's description:
> Add base::TimeDelta::Max().
>
> TimeDelta::Max() is a maximum timedelta, larger than any timedelta you
> can compare it to. The results of adding it to a time, or another time
> delta are undefined.
>
> R=ajwong@chromium.org,mkwst@chromium.org,jar@chromium.org
> TBR=jamesr@chomium.org,acolwell@chromium.org,nick@chromium.org
> BUG=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253502
TBR=ajwong@chromium.org,mkwst@chromium.org,jar@chromium.org,phajdan.jr@chromium.org,gavinp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Patch Set 1 #
Created: 6 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (0 generated)
|