Fix 4f gradient swizzle post http://crrev.com/1774523002

Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

Also remove an unused Interval ctor.

R=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1770153002

Committed: https://skia.googlesource.com/skia/+/d8a4f772115bbb9d50c0e73613bdd879833da690

[f(malita), 2016-03-07 21:43:30]

Description was changed from

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

R=reed@google.com
==========

to

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-03-07 21:44:15]

Description was changed from

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

Also remove an unused Interval ctor.

R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[f(malita), 2016-03-07 21:44:15]

fmalita@chromium.org changed reviewers:
+ mtklein@google.com

[f(malita), 2016-03-07 21:47:51]

depends on https://codereview.chromium.org/1774523002/

[reed1, 2016-03-08 14:47:23]

lgtm

better to land this separately, or roll it into the other CL?

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
File src/effects/gradients/Sk4fLinearGradient.cpp (right):

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
src/effects/gradients/Sk4fLinearGradient.cpp:320: const float paintAlpha =
rec.fPaint->getAlpha() / 255.0f;
? does this always do a float divide now, instead of a multiply?

[mtklein, 2016-03-08 14:57:51]

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
File src/effects/gradients/Sk4fLinearGradient.cpp (right):

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
src/effects/gradients/Sk4fLinearGradient.cpp:320: const float paintAlpha =
rec.fPaint->getAlpha() / 255.0f;
On 2016/03/08 14:47:23, reed1 wrote:
> ? does this always do a float divide now, instead of a multiply?

Yes, that will do a divide.

My division primer:
   x / 255.0f     ~~> divide
   x * 1/255.0f  ~~> multiply _and_ divide
   x * (1/255.0f) ~~> multiply

(It doesn't matter if you write 1.0f/255.0f 1/255.0f or 1.0f/255.)

[f(malita), 2016-03-08 15:04:46]

On 2016/03/08 14:47:23, reed1 wrote:
> lgtm
> 
> better to land this separately, or roll it into the other CL?

Let's land separately, no reason to delay your CL any longer.

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
File src/effects/gradients/Sk4fLinearGradient.cpp (right):

https://codereview.chromium.org/1770153002/diff/40001/src/effects/gradients/S...
src/effects/gradients/Sk4fLinearGradient.cpp:320: const float paintAlpha =
rec.fPaint->getAlpha() / 255.0f;
On 2016/03/08 14:47:23, reed1 wrote:
> ? does this always do a float divide now, instead of a multiply?

I guess so, I should change it back to multiplication form even if only one op
per context creation.

[f(malita), 2016-03-08 15:07:12]

On 2016/03/08 14:57:51, mtklein wrote:
>    x * (1/255.0f) ~~> multiply


Done.

[f(malita), 2016-03-08 18:10:18]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 18:10:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770153002/60001

[commit-bot: I haz the power, 2016-03-08 18:19:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 18:19:35]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-03-08 18:19:47]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-03-08 18:19:47]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1770153002/#ps60001
(title: "float mult")

[commit-bot: I haz the power, 2016-03-08 18:19:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770153002/60001

[commit-bot: I haz the power, 2016-03-08 18:20:52]

Description was changed from

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

Also remove an unused Interval ctor.

R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix 4f gradient swizzle post http://crrev.com/1774523002

* store interval colors in pm4f-natural/RGBA order
* swizzle to dst order during interval advance

Also remove an unused Interval ctor.

R=reed@google.com
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/d8a4f772115bbb9d50c0e73613bdd879833da690
==========

[commit-bot: I haz the power, 2016-03-08 18:20:53]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d8a4f772115bbb9d50c0e73613bdd879833da690