Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177013006: [Android] Move LoadUrl from Tab upstream. (Closed)

Created:
6 years, 9 months ago by Ted C
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add java method #

Total comments: 6

Patch Set 3 : Indenting fix #

Patch Set 4 : Address comments #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -6 lines) Patch
A + chrome/android/java/TabLoadStatus.template View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 4 chunks +37 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 2 3 4 chunks +24 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 2 3 5 chunks +117 lines, -0 lines 0 comments Download
A chrome/browser/android/tab_load_status.h View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Ted C
PTAL
6 years, 9 months ago (2014-03-06 22:03:58 UTC) #1
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/177013006/diff/20001/chrome/browser/android/tab_android.cc File chrome/browser/android/tab_android.cc (right): https://codereview.chromium.org/177013006/diff/20001/chrome/browser/android/tab_android.cc#newcode206 chrome/browser/android/tab_android.cc:206: gurl && prerender_contents->has_finished_loading()) { gurl on line above? ...
6 years, 9 months ago (2014-03-06 22:21:31 UTC) #2
Ted C
https://codereview.chromium.org/177013006/diff/20001/chrome/browser/android/tab_android.cc File chrome/browser/android/tab_android.cc (right): https://codereview.chromium.org/177013006/diff/20001/chrome/browser/android/tab_android.cc#newcode206 chrome/browser/android/tab_android.cc:206: gurl && prerender_contents->has_finished_loading()) { On 2014/03/06 22:21:32, David Trainor ...
6 years, 9 months ago (2014-03-06 22:30:43 UTC) #3
Ted C
6 years, 9 months ago (2014-03-06 22:30:45 UTC) #4
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-06 23:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/177013006/60001
6 years, 9 months ago (2014-03-06 23:22:31 UTC) #6
Nico
chrome.gyp lgtm omg so good
6 years, 9 months ago (2014-03-06 23:29:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 00:23:28 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53963
6 years, 9 months ago (2014-03-07 00:23:29 UTC) #9
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-07 05:00:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/177013006/50010
6 years, 9 months ago (2014-03-07 05:04:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:23:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 06:23:09 UTC) #13
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-07 06:48:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/177013006/50010
6 years, 9 months ago (2014-03-07 06:50:05 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 07:08:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 07:08:39 UTC) #17
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-07 07:12:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/177013006/50010
6 years, 9 months ago (2014-03-07 07:12:26 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 07:30:37 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 07:30:38 UTC) #21
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 9 months ago (2014-03-07 14:39:14 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/177013006/50010
6 years, 9 months ago (2014-03-07 14:46:43 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 16:47:34 UTC) #24
Message was sent while issue was closed. 
Change committed as 255636

Powered by Google App Engine
This is Rietveld 408576698