Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177013005: Componentize AutofillMetricsTest. (Closed)

Created:
6 years, 9 months ago by blundell
Modified:
6 years, 9 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Componentize AutofillMetricsTest. The componentization is straightforward, following the patterns of other Autofill test componentizations. BUG=303083 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255908

Patch Set 1 #

Total comments: 2

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 9 chunks +19 lines, -33 lines 0 comments Download
M components/components_tests.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blundell
Dependent on https://codereview.chromium.org/177923004/
6 years, 9 months ago (2014-03-06 20:23:10 UTC) #1
Ilya Sherman
https://codereview.chromium.org/177013005/diff/1/components/autofill/core/browser/autofill_metrics_unittest.cc File components/autofill/core/browser/autofill_metrics_unittest.cc (left): https://codereview.chromium.org/177013005/diff/1/components/autofill/core/browser/autofill_metrics_unittest.cc#oldcode260 components/autofill/core/browser/autofill_metrics_unittest.cc:260: autofill::test::DisableSystemServices(profile()); Something like this is still needed, right?
6 years, 9 months ago (2014-03-06 23:20:58 UTC) #2
blundell
Thanks! https://codereview.chromium.org/177013005/diff/1/components/autofill/core/browser/autofill_metrics_unittest.cc File components/autofill/core/browser/autofill_metrics_unittest.cc (left): https://codereview.chromium.org/177013005/diff/1/components/autofill/core/browser/autofill_metrics_unittest.cc#oldcode260 components/autofill/core/browser/autofill_metrics_unittest.cc:260: autofill::test::DisableSystemServices(profile()); On 2014/03/06 23:20:58, Ilya Sherman wrote: > ...
6 years, 9 months ago (2014-03-07 15:07:14 UTC) #3
Ilya Sherman
LGTM, thanks :)
6 years, 9 months ago (2014-03-07 23:36:24 UTC) #4
blundell
6 years, 9 months ago (2014-03-10 08:30:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r255908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698