Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1770103003: Avoid WeakProcessingHashTableHelper<> type redefinitions. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid WeakProcessingHashTableHelper<> type redefinitions. R=haraken BUG= Committed: https://crrev.com/1d3dd7dbbeea929087e089ae1e8acdaa4fae80aa Cr-Commit-Position: refs/heads/master@{#379820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M third_party/WebKit/Source/wtf/HashTable.h View 4 chunks +28 lines, -29 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sof
4 years, 9 months ago (2016-03-08 10:15:26 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-08 10:31:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770103003/1
4 years, 9 months ago (2016-03-08 10:33:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34989)
4 years, 9 months ago (2016-03-08 11:50:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770103003/1
4 years, 9 months ago (2016-03-08 12:00:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 13:25:45 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 13:27:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d3dd7dbbeea929087e089ae1e8acdaa4fae80aa
Cr-Commit-Position: refs/heads/master@{#379820}

Powered by Google App Engine
This is Rietveld 408576698