SurfaceTexture* => gpu/ipc/common

gpu/ipc/common/BUILD.gn

Index: gpu/ipc/common/BUILD.gn
diff --git a/gpu/ipc/common/BUILD.gn b/gpu/ipc/common/BUILD.gn
index 5d4cb18d692da35a117f9ba0beccbfb370dde78c..1d5b553f9b649757ac59b3aeea7c6b94910fb427 100644
--- a/gpu/ipc/common/BUILD.gn
+++ b/gpu/ipc/common/BUILD.gn
@@ -3,20 +3,12 @@
 # found in the LICENSE file.
 
 group("common") {
-  if (is_component_build) {
-    public_deps = [
-      "//gpu",
-    ]
-  } else {
-    public_deps = [
-      ":ipc_common_sources",
-    ]
-  }
+  public_deps = [

[Fady Samuel, 2016/03/08 05:38:54]

Hey Mark! I don't really know what I'm doing here. Could you please help me
understand this? I think what this is saying is for a component build, then you
link against the gpu component rather than adding this source to your
compilation unit. Am I right? How do I debug why this existing strategy is
broken? Thanks!

../../content/common/gpu/stream_texture_android.cc:257: error: undefined
reference to 'gpu::SurfaceTexturePeer::GetInstance()'
../../content/browser/android/browser_surface_texture_manager.cc:76: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:77: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:76: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:77: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:81: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:81: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/in_process_surface_texture_manager.cc:71: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/renderer/media/android/stream_texture_factory_synchronous_impl.cc:186:
error: undefined reference to 'gpu::SurfaceTexturePeer::GetInstance()'
../../content/app/android/child_process_service.cc:41: error: undefined
reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'

[Mark Dittmer, 2016/03/08 18:28:11]

I think you're better off making the source_set below into a component, and
having dependees on :common, instead, depend on your component.

Don't forget to mirror this structure in gyp too.

+    ":ipc_common_sources",
+  ]
 }
 
 source_set("ipc_common_sources") {
-  visibility = [ "//gpu/*" ]
-
   sources = [
     "gpu_command_buffer_traits.cc",
     "gpu_command_buffer_traits.h",
@@ -25,6 +17,15 @@ source_set("ipc_common_sources") {
     "memory_stats.h",
   ]
 
+  if (is_android) {
+    sources += [
+      "surface_texture_manager.cc",
+      "surface_texture_manager.h",
+      "surface_texture_peer.cc",
+      "surface_texture_peer.h",
+    ]
+  }
+
   configs += [
     "//gpu:gpu_implementation",
     "//third_party/khronos:khronos_headers",