SurfaceTexture* => gpu/ipc/common

mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/de3cdcdce42f1a807fab41190f96273ec62c704d
Cr-Commit-Position: refs/heads/master@{#380240}

[Fady Samuel, 2016-03-07 18:57:01]

Description was changed from

==========
SurfaceTexture* => gpu/ipc/common

BUG=
==========

to

==========
SurfaceTexture* => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-07 18:57:57]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 18:58:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/1

[commit-bot: I haz the power, 2016-03-07 19:13:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 19:13:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-03-07 20:14:07]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 20:14:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/20001

[commit-bot: I haz the power, 2016-03-07 20:58:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 20:58:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Fady Samuel, 2016-03-08 05:38:54]

fsamuel@chromium.org changed reviewers:
+ markdittmer@chromium.org

[Fady Samuel, 2016-03-08 05:38:55]

Hey Mark!

This is still a work in progress. I'm not sure why it's broken. My GN is not
good enough. Could you please teach me your newly acquired GN foo? Thanks! 

Fady

https://codereview.chromium.org/1770073002/diff/40001/gpu/ipc/common/BUILD.gn
File gpu/ipc/common/BUILD.gn (right):

https://codereview.chromium.org/1770073002/diff/40001/gpu/ipc/common/BUILD.gn...
gpu/ipc/common/BUILD.gn:6: public_deps = [
Hey Mark! I don't really know what I'm doing here. Could you please help me
understand this? I think what this is saying is for a component build, then you
link against the gpu component rather than adding this source to your
compilation unit. Am I right? How do I debug why this existing strategy is
broken? Thanks!

../../content/common/gpu/stream_texture_android.cc:257: error: undefined
reference to 'gpu::SurfaceTexturePeer::GetInstance()'
../../content/browser/android/browser_surface_texture_manager.cc:76: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:77: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:76: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:77: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:81: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:81: error:
undefined reference to
'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/browser_surface_texture_manager.cc:82: error:
undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
../../content/browser/android/in_process_surface_texture_manager.cc:71: error:
undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
../../content/renderer/media/android/stream_texture_factory_synchronous_impl.cc:186:
error: undefined reference to 'gpu::SurfaceTexturePeer::GetInstance()'
../../content/app/android/child_process_service.cc:41: error: undefined
reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'

[Fady Samuel, 2016-03-08 14:18:21]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 14:18:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/40001

[commit-bot: I haz the power, 2016-03-08 14:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 14:39:38]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Mark Dittmer, 2016-03-08 18:28:11]

Added comments on build target structures, as per our discussion.

https://codereview.chromium.org/1770073002/diff/40001/gpu/ipc/common/BUILD.gn
File gpu/ipc/common/BUILD.gn (right):

https://codereview.chromium.org/1770073002/diff/40001/gpu/ipc/common/BUILD.gn...
gpu/ipc/common/BUILD.gn:6: public_deps = [
On 2016/03/08 05:38:54, Fady Samuel wrote:
> Hey Mark! I don't really know what I'm doing here. Could you please help me
> understand this? I think what this is saying is for a component build, then
you
> link against the gpu component rather than adding this source to your
> compilation unit. Am I right? How do I debug why this existing strategy is
> broken? Thanks!
> 
> ../../content/common/gpu/stream_texture_android.cc:257: error: undefined
> reference to 'gpu::SurfaceTexturePeer::GetInstance()'
> ../../content/browser/android/browser_surface_texture_manager.cc:76: error:
> undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
> ../../content/browser/android/browser_surface_texture_manager.cc:77: error:
> undefined reference to
> 'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
> ../../content/browser/android/browser_surface_texture_manager.cc:76: error:
> undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
> ../../content/browser/android/browser_surface_texture_manager.cc:77: error:
> undefined reference to
> 'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
> ../../content/browser/android/browser_surface_texture_manager.cc:81: error:
> undefined reference to
> 'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
> ../../content/browser/android/browser_surface_texture_manager.cc:82: error:
> undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
> ../../content/browser/android/browser_surface_texture_manager.cc:81: error:
> undefined reference to
> 'gpu::SurfaceTexturePeer::InitInstance(gpu::SurfaceTexturePeer*)'
> ../../content/browser/android/browser_surface_texture_manager.cc:82: error:
> undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
> ../../content/browser/android/browser_surface_texture_manager.cc:82: error:
> undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
> ../../content/browser/android/browser_surface_texture_manager.cc:82: error:
> undefined reference to 'gpu::SurfaceTexturePeer::~SurfaceTexturePeer()'
> ../../content/browser/android/in_process_surface_texture_manager.cc:71: error:
> undefined reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'
>
../../content/renderer/media/android/stream_texture_factory_synchronous_impl.cc:186:
> error: undefined reference to 'gpu::SurfaceTexturePeer::GetInstance()'
> ../../content/app/android/child_process_service.cc:41: error: undefined
> reference to 'gpu::SurfaceTexturePeer::SurfaceTexturePeer()'

I think you're better off making the source_set below into a component, and
having dependees on :common, instead, depend on your component.

Don't forget to mirror this structure in gyp too.

[Fady Samuel, 2016-03-09 03:02:14]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 03:02:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/60001

[commit-bot: I haz the power, 2016-03-09 05:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 05:03:19]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[Fady Samuel, 2016-03-09 13:14:51]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 13:15:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/60001

[commit-bot: I haz the power, 2016-03-09 13:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 13:19:21]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-03-09 16:36:42]

Description was changed from

==========
SurfaceTexture* => gpu/ipc/common

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc to allow code reuse
in Mus, I'm moving some android specific code: SurfaceTextureManager and
SurfaceTexturePeer to gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-09 16:36:50]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 16:37:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/80001

[commit-bot: I haz the power, 2016-03-09 17:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 17:56:12]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-03-09 17:56:39]

Description was changed from

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc to allow code reuse
in Mus, I'm moving some android specific code: SurfaceTextureManager and
SurfaceTexturePeer to gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific code:
SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-09 17:57:20]

Description was changed from

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific code:
SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-03-09 17:57:52]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-03-09 17:57:53]

Hi Antoine,

Please take a look! Thanks!

Fady

[piman, 2016-03-09 19:00:33]

https://codereview.chromium.org/1770073002/diff/80001/gpu/ipc/common/BUILD.gn
File gpu/ipc/common/BUILD.gn (left):

https://codereview.chromium.org/1770073002/diff/80001/gpu/ipc/common/BUILD.gn...
gpu/ipc/common/BUILD.gn:14: }
Did you intend to remove this code? I think this is to reflect the similar logic
in gpu.gyp:

- in non-component builds, gpu_ipc_common is a static library, gpu is a
none-target that depends on gpu_ipc_common
- in component builds, gpu_ipc_common is a none-target, instead its sources are
part of the gpu target, which is a dynamic library, so dependents are made to
depend on gpu instead.

[Fady Samuel, 2016-03-09 19:57:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-03-09 19:58:26]

PTAL

https://codereview.chromium.org/1770073002/diff/80001/gpu/ipc/common/BUILD.gn
File gpu/ipc/common/BUILD.gn (left):

https://codereview.chromium.org/1770073002/diff/80001/gpu/ipc/common/BUILD.gn...
gpu/ipc/common/BUILD.gn:14: }
On 2016/03/09 19:00:33, piman wrote:
> Did you intend to remove this code? I think this is to reflect the similar
logic
> in gpu.gyp:
> 
> - in non-component builds, gpu_ipc_common is a static library, gpu is a
> none-target that depends on gpu_ipc_common
> - in component builds, gpu_ipc_common is a none-target, instead its sources
are
> part of the gpu target, which is a dynamic library, so dependents are made to
> depend on gpu instead.

I was trying to get the bots happy and trying out things. I've restored this and
sent it back to the bots to chew on.

[commit-bot: I haz the power, 2016-03-09 19:58:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/100001

[piman, 2016-03-09 21:13:31]

lgtm

[commit-bot: I haz the power, 2016-03-09 21:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 21:39:32]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-03-09 21:40:26]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-03-09 21:41:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/100001

[commit-bot: I haz the power, 2016-03-09 21:54:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 21:54:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-03-09 21:56:12]

fsamuel@chromium.org changed reviewers:
+ tsepez@chromium.org

[Fady Samuel, 2016-03-09 21:56:13]

+tsepez@ for gpu/ipc/common + content/common/gpu/gpu_messages.h

This is a mechanical move. No changes to IPC messages.

[Fady Samuel, 2016-03-09 21:56:15]

+tsepez@ for gpu/ipc/common + content/common/gpu/gpu_messages.h

This is a mechanical move. No changes to IPC messages.

[Tom Sepez, 2016-03-09 22:05:19]

Messages LGTM.

[Fady Samuel, 2016-03-09 22:05:44]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-03-09 22:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1770073002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1770073002/100001

[commit-bot: I haz the power, 2016-03-09 22:12:44]

Description was changed from

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-09 22:12:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-09 22:47:53]

Description was changed from

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc 
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to 
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
mustash: SurfaceTexture* => gpu/ipc/common

As part of the effort to move content/common/gpu => gpu/ipc
to allow code reuse in Mus, I'm moving some android specific
code: SurfaceTextureManager and SurfaceTexturePeer to
gpu/ipc/common.

BUG=586371
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/de3cdcdce42f1a807fab41190f96273ec62c704d
Cr-Commit-Position: refs/heads/master@{#380240}
==========

[commit-bot: I haz the power, 2016-03-09 22:47:55]

Patchset 6 (id:??) landed as
https://crrev.com/de3cdcdce42f1a807fab41190f96273ec62c704d
Cr-Commit-Position: refs/heads/master@{#380240}