Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177003025: Remove TextTrackClient interface to simplify TextTrack code. (Closed)

Created:
6 years, 10 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove TextTrackClient interface to simplify TextTrack code. Removing the TextTrackClient interface because it was obscuring calls made to the HTMLMediaElement and wasn't really providing much value. Calls made to the HTMLMediaElement are much clearer now and it is easier to follow what happens when tracks are removed from the TextTrackList. BUG=249427 TEST=All existing LayoutTests still pass R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168534

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address CR comments #

Patch Set 3 : Move setTrackList(0) to destructor #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -128 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTrackElement.h View 2 chunks +1 line, -9 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 2 chunks +1 line, -41 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 5 chunks +16 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 5 chunks +5 lines, -18 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 2 12 chunks +28 lines, -28 lines 0 comments Download
M Source/core/html/track/TextTrackList.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 2 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
acolwell GONE FROM CHROMIUM
Here is the follow-up change I was talking about. It depends on https://codereview.chromium.org/177243018/
6 years, 10 months ago (2014-02-27 01:40:01 UTC) #1
adamk
lgtm % nits https://codereview.chromium.org/177003025/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/177003025/diff/1/Source/core/html/HTMLMediaElement.h#newcode235 Source/core/html/HTMLMediaElement.h:235: virtual void textTrackKindChanged(TextTrack*); Can these be ...
6 years, 10 months ago (2014-02-27 01:55:09 UTC) #2
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/177003025/diff/1/Source/core/html/HTMLMediaElement.h File Source/core/html/HTMLMediaElement.h (right): https://codereview.chromium.org/177003025/diff/1/Source/core/html/HTMLMediaElement.h#newcode235 Source/core/html/HTMLMediaElement.h:235: virtual void textTrackKindChanged(TextTrack*); On 2014/02/27 01:55:09, adamk wrote: > ...
6 years, 10 months ago (2014-02-27 03:57:06 UTC) #3
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-04 17:38:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/177003025/50001
6 years, 9 months ago (2014-03-04 17:39:12 UTC) #5
acolwell GONE FROM CHROMIUM
The CQ bit was unchecked by acolwell@chromium.org
6 years, 9 months ago (2014-03-05 19:13:57 UTC) #6
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-05 19:13:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/177003025/50001
6 years, 9 months ago (2014-03-05 20:54:10 UTC) #8
acolwell GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-05 21:15:56 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 manually as r168534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698