Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 177003009: Remove the enable-d3d11 flag so that d3d11 is enabled by default. (Closed)

Created:
6 years, 10 months ago by Geoff Lang
Modified:
6 years, 8 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, alokp, Paweł Hajdan Jr., ghost stip (do not use)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the enable-d3d11 flag so that d3d11 is enabled by default. BUG=258676 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260937

Patch Set 1 #

Patch Set 2 : Add DEPS roll. #

Patch Set 3 : Remove DEPS roll. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_win.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ui/gl/gl_switches.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_switches.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Geoff Lang
PTAL
6 years, 10 months ago (2014-02-26 15:23:56 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 10 months ago (2014-02-26 19:45:48 UTC) #2
Geoff Lang
On 2014/02/26 19:45:48, Ken Russell wrote: > lgtm @kbr Could you re-lgtm please? I had ...
6 years, 9 months ago (2014-02-27 21:16:25 UTC) #3
Ken Russell (switch to Gerrit)
LGTM again. FYI, LGTMs are sticky, so you don't need to get re-approval when updating ...
6 years, 9 months ago (2014-02-27 21:56:57 UTC) #4
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 9 months ago (2014-03-03 20:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/geofflang@chromium.org/177003009/40001
6 years, 9 months ago (2014-03-03 20:32:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:52:27 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53135
6 years, 9 months ago (2014-03-03 20:52:28 UTC) #8
Ken Russell (switch to Gerrit)
The presubmit failure is bogus, and is filed as http://crbug.com/348691 .
6 years, 9 months ago (2014-03-03 20:55:31 UTC) #9
Geoff Lang
On 2014/03/03 20:55:31, Ken Russell wrote: > The presubmit failure is bogus, and is filed ...
6 years, 9 months ago (2014-03-03 20:58:50 UTC) #10
bajones
Committed patchset #3 manually as r254571 (presubmit successful).
6 years, 9 months ago (2014-03-03 21:48:23 UTC) #11
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 9 months ago (2014-03-24 17:25:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/geofflang@chromium.org/177003009/40001
6 years, 9 months ago (2014-03-24 17:27:32 UTC) #13
Geoff Lang
The CQ bit was unchecked by geofflang@chromium.org
6 years, 9 months ago (2014-03-24 21:59:27 UTC) #14
bajones
Committed patchset #3 manually as r259028 (presubmit successful).
6 years, 9 months ago (2014-03-24 22:04:44 UTC) #15
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 9 months ago (2014-03-27 13:35:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/geofflang@chromium.org/177003009/40001
6 years, 9 months ago (2014-03-27 13:36:00 UTC) #17
commit-bot: I haz the power
Change committed as 259856
6 years, 9 months ago (2014-03-27 15:18:02 UTC) #18
Geoff Lang
The CQ bit was checked by geofflang@chromium.org
6 years, 8 months ago (2014-04-01 17:32:18 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/geofflang@chromium.org/177003009/60001
6 years, 8 months ago (2014-04-01 17:32:20 UTC) #20
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 20:23:15 UTC) #21
Message was sent while issue was closed. 
Change committed as 260937

Powered by Google App Engine
This is Rietveld 408576698