Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1770013004: Remove Resource::assertIsAlive(). (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
Nate Chapin, dcheng
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Resource::assertIsAlive(). Temporary release assert to diagnose a crash that got stuck. R=dcheng BUG=352043 Committed: https://crrev.com/099b82a733e4de66b2beedfeae4668912c231050 Cr-Commit-Position: refs/heads/master@{#379810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 5 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 5 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-08 10:38:29 UTC) #2
dcheng
lgtm
4 years, 9 months ago (2016-03-08 10:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770013004/1
4 years, 9 months ago (2016-03-08 10:42:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 11:55:15 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 11:56:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/099b82a733e4de66b2beedfeae4668912c231050
Cr-Commit-Position: refs/heads/master@{#379810}

Powered by Google App Engine
This is Rietveld 408576698