Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: ipc/ipc_message_templates_impl.h

Issue 1770013002: Replace base::Tuple in //ipc with std::tuple (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_ 5 #ifndef IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_
6 #define IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_ 6 #define IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_
7 7
Tom Sepez 2016/03/07 19:05:02 include tuple
tzik 2016/03/08 03:32:59 Done.
8 namespace IPC { 8 namespace IPC {
9 9
10 template <typename... Ts> 10 template <typename... Ts>
11 class ParamDeserializer : public MessageReplyDeserializer { 11 class ParamDeserializer : public MessageReplyDeserializer {
12 public: 12 public:
13 explicit ParamDeserializer(const base::Tuple<Ts&...>& out) : out_(out) {} 13 explicit ParamDeserializer(const std::tuple<Ts&...>& out) : out_(out) {}
14 14
15 bool SerializeOutputParameters(const IPC::Message& msg, 15 bool SerializeOutputParameters(const IPC::Message& msg,
16 base::PickleIterator iter) override { 16 base::PickleIterator iter) override {
17 return ReadParam(&msg, &iter, &out_); 17 return ReadParam(&msg, &iter, &out_);
18 } 18 }
19 19
20 base::Tuple<Ts&...> out_; 20 std::tuple<Ts&...> out_;
21 }; 21 };
22 22
23 template <typename Meta, typename... Ins> 23 template <typename Meta, typename... Ins>
24 MessageT<Meta, base::Tuple<Ins...>, void>::MessageT(Routing routing, 24 MessageT<Meta, std::tuple<Ins...>, void>::MessageT(Routing routing,
25 const Ins&... ins) 25 const Ins&... ins)
26 : Message(routing.id, ID, PRIORITY_NORMAL) { 26 : Message(routing.id, ID, PRIORITY_NORMAL) {
27 WriteParam(this, base::MakeRefTuple(ins...)); 27 WriteParam(this, std::tie(ins...));
28 } 28 }
29 29
30 template <typename Meta, typename... Ins> 30 template <typename Meta, typename... Ins>
31 bool MessageT<Meta, base::Tuple<Ins...>, void>::Read(const Message* msg, 31 bool MessageT<Meta, std::tuple<Ins...>, void>::Read(const Message* msg,
32 Param* p) { 32 Param* p) {
33 base::PickleIterator iter(*msg); 33 base::PickleIterator iter(*msg);
34 return ReadParam(msg, &iter, p); 34 return ReadParam(msg, &iter, p);
35 } 35 }
36 36
37 template <typename Meta, typename... Ins> 37 template <typename Meta, typename... Ins>
38 void MessageT<Meta, base::Tuple<Ins...>, void>::Log(std::string* name, 38 void MessageT<Meta, std::tuple<Ins...>, void>::Log(std::string* name,
39 const Message* msg, 39 const Message* msg,
40 std::string* l) { 40 std::string* l) {
41 if (name) 41 if (name)
42 *name = Meta::kName; 42 *name = Meta::kName;
43 if (!msg || !l) 43 if (!msg || !l)
44 return; 44 return;
45 Param p; 45 Param p;
46 if (Read(msg, &p)) 46 if (Read(msg, &p))
47 LogParam(p, l); 47 LogParam(p, l);
48 } 48 }
49 49
50 template <typename Meta, typename... Ins, typename... Outs> 50 template <typename Meta, typename... Ins, typename... Outs>
51 MessageT<Meta, base::Tuple<Ins...>, base::Tuple<Outs...>>::MessageT( 51 MessageT<Meta, std::tuple<Ins...>, std::tuple<Outs...>>::MessageT(
52 Routing routing, 52 Routing routing,
53 const Ins&... ins, 53 const Ins&... ins,
54 Outs*... outs) 54 Outs*... outs)
55 : SyncMessage( 55 : SyncMessage(
56 routing.id, 56 routing.id,
57 ID, 57 ID,
58 PRIORITY_NORMAL, 58 PRIORITY_NORMAL,
59 new ParamDeserializer<Outs...>(base::MakeRefTuple(*outs...))) { 59 new ParamDeserializer<Outs...>(std::tie(*outs...))) {
60 WriteParam(this, base::MakeRefTuple(ins...)); 60 WriteParam(this, std::tie(ins...));
61 } 61 }
62 62
63 template <typename Meta, typename... Ins, typename... Outs> 63 template <typename Meta, typename... Ins, typename... Outs>
64 bool MessageT<Meta, base::Tuple<Ins...>, base::Tuple<Outs...>>::ReadSendParam( 64 bool MessageT<Meta, std::tuple<Ins...>, std::tuple<Outs...>>::ReadSendParam(
65 const Message* msg, 65 const Message* msg,
66 SendParam* p) { 66 SendParam* p) {
67 base::PickleIterator iter = SyncMessage::GetDataIterator(msg); 67 base::PickleIterator iter = SyncMessage::GetDataIterator(msg);
68 return ReadParam(msg, &iter, p); 68 return ReadParam(msg, &iter, p);
69 } 69 }
70 70
71 template <typename Meta, typename... Ins, typename... Outs> 71 template <typename Meta, typename... Ins, typename... Outs>
72 bool MessageT<Meta, base::Tuple<Ins...>, base::Tuple<Outs...>>::ReadReplyParam( 72 bool MessageT<Meta, std::tuple<Ins...>, std::tuple<Outs...>>::ReadReplyParam(
73 const Message* msg, 73 const Message* msg,
74 ReplyParam* p) { 74 ReplyParam* p) {
75 base::PickleIterator iter = SyncMessage::GetDataIterator(msg); 75 base::PickleIterator iter = SyncMessage::GetDataIterator(msg);
76 return ReadParam(msg, &iter, p); 76 return ReadParam(msg, &iter, p);
77 } 77 }
78 78
79 template <typename Meta, typename... Ins, typename... Outs> 79 template <typename Meta, typename... Ins, typename... Outs>
80 void MessageT<Meta, 80 void MessageT<Meta,
81 base::Tuple<Ins...>, 81 std::tuple<Ins...>,
82 base::Tuple<Outs...>>::WriteReplyParams(Message* reply, 82 std::tuple<Outs...>>::WriteReplyParams(Message* reply,
83 const Outs&... outs) { 83 const Outs&... outs) {
84 WriteParam(reply, base::MakeRefTuple(outs...)); 84 WriteParam(reply, std::tie(outs...));
85 } 85 }
86 86
87 template <typename Meta, typename... Ins, typename... Outs> 87 template <typename Meta, typename... Ins, typename... Outs>
88 void MessageT<Meta, base::Tuple<Ins...>, base::Tuple<Outs...>>::Log( 88 void MessageT<Meta, std::tuple<Ins...>, std::tuple<Outs...>>::Log(
89 std::string* name, 89 std::string* name,
90 const Message* msg, 90 const Message* msg,
91 std::string* l) { 91 std::string* l) {
92 if (name) 92 if (name)
93 *name = Meta::kName; 93 *name = Meta::kName;
94 if (!msg || !l) 94 if (!msg || !l)
95 return; 95 return;
96 if (msg->is_sync()) { 96 if (msg->is_sync()) {
97 SendParam p; 97 SendParam p;
98 if (ReadSendParam(msg, &p)) 98 if (ReadSendParam(msg, &p))
99 LogParam(p, l); 99 LogParam(p, l);
100 AddOutputParamsToLog(msg, l); 100 AddOutputParamsToLog(msg, l);
101 } else { 101 } else {
102 ReplyParam p; 102 ReplyParam p;
103 if (ReadReplyParam(msg, &p)) 103 if (ReadReplyParam(msg, &p))
104 LogParam(p, l); 104 LogParam(p, l);
105 } 105 }
106 } 106 }
107 107
108 } // namespace IPC 108 } // namespace IPC
109 109
110 #endif // IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_ 110 #endif // IPC_IPC_MESSAGE_TEMPLATES_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698