Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1770013002: Replace base::Tuple in //ipc with std::tuple (Closed)

Created:
4 years, 9 months ago by tzik
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace base::Tuple in //ipc with std::tuple BUG=554987 Committed: https://crrev.com/55e3e4d3c52bf99bd8a710e55b1dcccea5e3acc6 Cr-Commit-Position: refs/heads/master@{#379759}

Patch Set 1 #

Total comments: 16

Patch Set 2 : +#include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -99 lines) Patch
M ipc/attachment_broker_mac_unittest.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download
M ipc/attachment_broker_privileged_mac.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M ipc/ipc_message_macros.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ipc/ipc_message_templates.h View 1 6 chunks +9 lines, -8 lines 0 comments Download
M ipc/ipc_message_templates_impl.h View 1 5 chunks +17 lines, -15 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 7 chunks +61 lines, -61 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770013002/1
4 years, 9 months ago (2016-03-07 16:59:19 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 18:35:55 UTC) #4
tzik
PTAL
4 years, 9 months ago (2016-03-07 18:48:14 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/1770013002/diff/1/ipc/attachment_broker_mac_unittest.cc File ipc/attachment_broker_mac_unittest.cc (right): https://codereview.chromium.org/1770013002/diff/1/ipc/attachment_broker_mac_unittest.cc#newcode12 ipc/attachment_broker_mac_unittest.cc:12: #include "base/command_line.h" #inlcude <tuple> https://codereview.chromium.org/1770013002/diff/1/ipc/attachment_broker_privileged_mac.cc File ipc/attachment_broker_privileged_mac.cc (right): ...
4 years, 9 months ago (2016-03-07 19:05:02 UTC) #7
tzik
https://codereview.chromium.org/1770013002/diff/1/ipc/attachment_broker_mac_unittest.cc File ipc/attachment_broker_mac_unittest.cc (right): https://codereview.chromium.org/1770013002/diff/1/ipc/attachment_broker_mac_unittest.cc#newcode12 ipc/attachment_broker_mac_unittest.cc:12: #include "base/command_line.h" On 2016/03/07 19:05:01, Tom Sepez wrote: > ...
4 years, 9 months ago (2016-03-08 03:32:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770013002/20001
4 years, 9 months ago (2016-03-08 03:33:42 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-08 05:02:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1770013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1770013002/20001
4 years, 9 months ago (2016-03-08 05:42:56 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 05:47:52 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 05:50:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55e3e4d3c52bf99bd8a710e55b1dcccea5e3acc6
Cr-Commit-Position: refs/heads/master@{#379759}

Powered by Google App Engine
This is Rietveld 408576698