Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch to use AudioDeviceFactory::GetOutputDevice() in AudioRendererMixerManager; AudioDeviceFactor… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index 73ce7ee88fcfdb0d8c7c57bd9bbbb6d5eaebb72f..a2977887f5ec3d63903c1b63cbdd83ebdd8c47a6 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -79,7 +79,7 @@ class CONTENT_EXPORT AudioDeviceFactory {
const url::Origin& security_origin);
// A helper to get device info in the absence of AudioOutputDevice.
- static media::OutputDeviceInfo GetOutputDeviceInfo(
+ static const media::OutputDeviceInfo GetOutputDeviceInfo(
tommi (sloooow) - chröme 2016/04/08 13:47:47 why this change? the caller can make the variable
o1ka 2016/04/08 19:07:25 No-no, no ref. Removing const to avoid confusion.
int render_frame_id,
int session_id,
const std::string& device_id,
@@ -99,7 +99,10 @@ class CONTENT_EXPORT AudioDeviceFactory {
// functions to provide alternate audio device implementations.
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
- virtual scoped_refptr<media::AudioRendererSink> CreateAudioRendererMixerSink(
+
+ // Creates a final sink in the rendering pipeline, which represents the actual
+ // output device.
+ virtual scoped_refptr<media::AudioRendererSink> CreateFinalAudioRendererSink(
int render_frame_id,
int sesssion_id,
const std::string& device_id,
@@ -127,6 +130,12 @@ class CONTENT_EXPORT AudioDeviceFactory {
// create the default AudioRendererSinks.
static AudioDeviceFactory* factory_;
+ static scoped_refptr<media::AudioRendererSink> NewFinalAudioRendererSink(
+ int render_frame_id,
+ int session_id,
+ const std::string& device_id,
+ const url::Origin& security_origin);
+
DISALLOW_COPY_AND_ASSIGN(AudioDeviceFactory);
};

Powered by Google App Engine
This is Rietveld 408576698