Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment and bug ref to remove AudioManagerBase dependency Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_mixer_manager.cc
diff --git a/content/renderer/media/audio_renderer_mixer_manager.cc b/content/renderer/media/audio_renderer_mixer_manager.cc
index 14359b3b967ad00406c2443742f1904e0fe8da70..e29ba931b2759495308e2e18cf57ead5e7ca94fe 100644
--- a/content/renderer/media/audio_renderer_mixer_manager.cc
+++ b/content/renderer/media/audio_renderer_mixer_manager.cc
@@ -10,7 +10,7 @@
#include "base/bind_helpers.h"
#include "build/build_config.h"
#include "content/renderer/media/audio_device_factory.h"
-#include "media/audio/audio_output_device.h"
+#include "media/audio/audio_manager_base.h"
#include "media/base/audio_hardware_config.h"
#include "media/base/audio_renderer_mixer.h"
#include "media/base/audio_renderer_mixer_input.h"
@@ -27,14 +27,23 @@ AudioRendererMixerManager::~AudioRendererMixerManager() {
media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(
int source_render_frame_id,
+ int session_id,
const std::string& device_id,
const url::Origin& security_origin) {
+ // base::Unretained() is safe since AudioRendererMixerManager lives on the
+ // renderer thread and is destroyed on renderer thread destruction.
return new media::AudioRendererMixerInput(
base::Bind(&AudioRendererMixerManager::GetMixer, base::Unretained(this),
source_render_frame_id),
base::Bind(&AudioRendererMixerManager::RemoveMixer,
base::Unretained(this), source_render_frame_id),
- device_id,
+ // TODO(olka) remove the dependency on AudioManagerBase,
+ // https://crbug.com/02581
+ media::AudioManagerBase::UseSessionIdToSelectDevice(session_id, device_id)
+ ? AudioDeviceFactory::GetOutputDeviceInfo(
+ source_render_frame_id, session_id, device_id, security_origin)
+ .device_id()
+ : device_id,
security_origin);
}
« no previous file with comments | « content/renderer/media/audio_renderer_mixer_manager.h ('k') | content/renderer/media/audio_renderer_mixer_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698