media/audio/audio_manager_base.cc - Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_manager_base.cc

Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_platform_audio_output.cc ('K') | « media/audio/audio_manager_base.h ('k') | media/audio/audio_output_device.h » ('j') | media/audio/audio_output_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/audio/audio_manager_base.cc

diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc

index 4f7e676d21aa3188bc42b682bc8f52b71a3388d8..e6f55c3959379bc245c97e091a4723f9354c914b 100644

--- a/media/audio/audio_manager_base.cc

+++ b/media/audio/audio_manager_base.cc

@@ -77,7 +77,8 @@ class AudioManagerBase::CompareByParams {

const DispatcherParams* dispatcher_;

};

-static bool IsDefaultDeviceId(const std::string& device_id) {

+// static

+bool AudioManagerBase::IsDefaultDeviceId(const std::string& device_id) {

Guido Urdaneta 2016/03/08 14:53:09 Change ARH to use this one instead of the identica

Henrik Grunell 2016/03/08 21:09:57 Move this so that the order of member functions is

o1ka 2016/04/05 15:13:38 Done.

o1ka 2016/04/05 15:13:38 Which order is broken?

return device_id.empty() || device_id == AudioManagerBase::kDefaultDeviceId;

}

« content/renderer/pepper/pepper_platform_audio_output.cc ('K') | « media/audio/audio_manager_base.h ('k') | media/audio/audio_output_device.h » ('j') | media/audio/audio_output_device.h » ('J')