Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased with respect to OutputDevice->OutputDeviceInfo change, fixed AOD race, addressed review com… Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/audio_renderer_mixer_manager.h" 5 #include "content/renderer/media/audio_renderer_mixer_manager.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "content/renderer/media/audio_device_factory.h" 12 #include "content/renderer/media/audio_device_factory.h"
13 #include "media/audio/audio_output_device.h" 13 #include "media/audio/audio_manager_base.h"
14 #include "media/base/audio_hardware_config.h" 14 #include "media/base/audio_hardware_config.h"
15 #include "media/base/audio_renderer_mixer.h" 15 #include "media/base/audio_renderer_mixer.h"
16 #include "media/base/audio_renderer_mixer_input.h" 16 #include "media/base/audio_renderer_mixer_input.h"
17 17
18 namespace content { 18 namespace content {
19 19
20 AudioRendererMixerManager::AudioRendererMixerManager() {} 20 AudioRendererMixerManager::AudioRendererMixerManager() {}
21 21
22 AudioRendererMixerManager::~AudioRendererMixerManager() { 22 AudioRendererMixerManager::~AudioRendererMixerManager() {
23 // References to AudioRendererMixers may be owned by garbage collected 23 // References to AudioRendererMixers may be owned by garbage collected
24 // objects. During process shutdown they may be leaked, so, transitively, 24 // objects. During process shutdown they may be leaked, so, transitively,
25 // |mixers_| may leak (i.e., may be non-empty at this time) as well. 25 // |mixers_| may leak (i.e., may be non-empty at this time) as well.
26 } 26 }
27 27
28 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput( 28 media::AudioRendererMixerInput* AudioRendererMixerManager::CreateInput(
29 int source_render_frame_id, 29 int source_render_frame_id,
30 int session_id,
30 const std::string& device_id, 31 const std::string& device_id,
31 const url::Origin& security_origin) { 32 const url::Origin& security_origin) {
33 std::string new_device_id(device_id);
Guido Urdaneta 2016/04/07 11:14:28 We can avoid this string copy. The code will be sl
o1ka 2016/04/07 12:40:49 Done.
34
35 if (media::AudioManagerBase::UseSessionIdToSelectDevice(session_id,
36 device_id)) {
37 // Output sink should be selected basing on |session_id|
38 scoped_refptr<media::AudioRendererSink> sink_from_session_id =
39 AudioDeviceFactory::NewAudioRendererMixerSink(
40 source_render_frame_id, session_id, device_id, security_origin);
41 new_device_id = sink_from_session_id->GetOutputDeviceInfo().device_id();
42
43 // TODO(olka): Cache it and reuse, http://crbug.com/586161
44 sink_from_session_id->Stop();
45 }
46
47 // At this point the output device is represented by |new_device_id| and
48 // |session_id| can (and should) be safely ignored.
32 return new media::AudioRendererMixerInput( 49 return new media::AudioRendererMixerInput(
33 base::Bind(&AudioRendererMixerManager::GetMixer, base::Unretained(this), 50 base::Bind(&AudioRendererMixerManager::GetMixer, base::Unretained(this),
34 source_render_frame_id), 51 source_render_frame_id),
35 base::Bind(&AudioRendererMixerManager::RemoveMixer, 52 base::Bind(&AudioRendererMixerManager::RemoveMixer,
36 base::Unretained(this), source_render_frame_id), 53 base::Unretained(this), source_render_frame_id),
37 device_id, 54 new_device_id, security_origin);
38 security_origin);
39 } 55 }
40 56
41 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer( 57 media::AudioRendererMixer* AudioRendererMixerManager::GetMixer(
42 int source_render_frame_id, 58 int source_render_frame_id,
43 const media::AudioParameters& params, 59 const media::AudioParameters& params,
44 const std::string& device_id, 60 const std::string& device_id,
45 const url::Origin& security_origin, 61 const url::Origin& security_origin,
46 media::OutputDeviceStatus* device_status) { 62 media::OutputDeviceStatus* device_status) {
47 // Effects are not passed through to output creation, so ensure none are set. 63 // Effects are not passed through to output creation, so ensure none are set.
48 DCHECK_EQ(params.effects(), media::AudioParameters::NO_EFFECTS); 64 DCHECK_EQ(params.effects(), media::AudioParameters::NO_EFFECTS);
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 const std::string& device_id, 148 const std::string& device_id,
133 const url::Origin& security_origin) 149 const url::Origin& security_origin)
134 : source_render_frame_id(source_render_frame_id), 150 : source_render_frame_id(source_render_frame_id),
135 params(params), 151 params(params),
136 device_id(device_id), 152 device_id(device_id),
137 security_origin(security_origin) {} 153 security_origin(security_origin) {}
138 154
139 AudioRendererMixerManager::MixerKey::MixerKey(const MixerKey& other) = default; 155 AudioRendererMixerManager::MixerKey::MixerKey(const MixerKey& other) = default;
140 156
141 } // namespace content 157 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698