media/base/audio_renderer_mixer_sink.h - Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/audio_renderer_mixer_sink.h

Issue 1769933002: Looking up device id by session id for AudioRendererMixerInput (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef MEDIA_BASE_AUDIO_RENDERER_MIXER_SINK_H_

	5 #define MEDIA_BASE_AUDIO_RENDERER_MIXER_SINK_H_

	6

	7 #include <string>

	8

	9 #include "media/base/audio_renderer_sink.h"

	10

	11 namespace media {

	12

	13 // Special sink to be used by AudioRendererMixer

	14 class AudioRendererMixerSink : public AudioRendererSink {
	Guido Urdaneta 2016/03/08 14:53:09 Why not add GetDeviceId() to OutputDevice instead Why not add GetDeviceId() to OutputDevice instead of introducing a new interface just to provide the device ID, especially considering that a device ID looks more related to an OutputDevice than to a Mixer. o1ka 2016/04/05 15:13:38 Addressed in another CL Show quoted text On 2016/03/08 14:53:09, Guido Urdaneta wrote: > Why not add GetDeviceId() to OutputDevice instead of introducing a new interface > just to provide the device ID, especially considering that a device ID looks > more related to an OutputDevice than to a Mixer. Addressed in another CL
	15 public:

	16 virtual std::string GetDeviceId() = 0;

	17

	18 protected:

	19 ~AudioRendererMixerSink() override{};
	Guido Urdaneta 2016/03/08 14:53:09 space after override. space after override.
	20 };

	21

	22 } // namespace media

	23

	24 #endif // MEDIA_BASE_AUDIO_RENDERER_MIXER_SINK_H_

OLD	NEW

« media/audio/audio_output_device.cc ('K') | « media/audio/audio_output_ipc.h ('k') | media/base/fake_output_device.h » ('j') | media/base/mock_audio_renderer_sink.h » ('J')