Issue 176993010: Start to implicitly include \n in rc_header_format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 176993010: Start to implicitly include \n in rc_header_format. (Closed)

Created:
6 years, 9 months ago by Jói

Modified:
6 years, 9 months ago

Reviewers:
aurimas (slooooooooow)

CC:
grit-developer_googlegroups.com

Base URL:
https://grit-i18n.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Start to implicitly include \n in rc_header_format. Certain tools such as ninja perform escaping on the arguments passed to grit and that makes it difficult to pass \n at the end of the rc_header_format. This CL makes the new line at the end implicit by adding automatically. BUG=338759 Landing for aurimas@chromium.org, patch from issue 183513005. Committed: https://code.google.com/p/grit-i18n/source/detail?r=155

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	grit/format/rc_header.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	grit/format/rc_header_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	grit/tool/build.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

6 years, 9 months ago (2014-03-03 14:36:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r155 (presubmit successful).

Expand Messages | Collapse Messages