Issue 176993004: Print properly signed displacement in IA32 disassembler.

Issue 176993004: Print properly signed displacement in IA32 disassembler. (Closed)

Created:
6 years, 10 months ago by Michael Starzinger

Modified:
6 years, 9 months ago

Reviewers:
titzer, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Print properly signed displacement in IA32 disassembler. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19652

Patch Set 1 #

Total comments: 8

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/ia32/disasm-ia32.cc	View		1 chunk	+6 lines, -2 lines	8 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Roughly once every three months I catch myself wondering why the displacement offset of a ...

6 years, 10 months ago (2014-02-25 13:57:30 UTC) #1

Michael Starzinger

Committed patchset #1 manually as r19652 (tree was closed).

6 years, 9 months ago (2014-03-04 13:07:09 UTC) #3

titzer

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc File src/ia32/disasm-ia32.cc (right): https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode410 src/ia32/disasm-ia32.cc:410: AppendToBuffer("[%s*%d+0x%x]", Here too! https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newcode440 src/ia32/disasm-ia32.cc:440: AppendToBuffer("[%s+0x%x]", (this->*register_name)(rm), disp); Here ...

6 years, 9 months ago (2014-03-04 13:43:34 UTC) #4

Michael Starzinger

6 years, 9 months ago (2014-03-04 18:29:52 UTC) #5

Message was sent while issue was closed.

Followup is at https://codereview.chromium.org/178193028/ from here on. I
addressed your comment in that CL.

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc
File src/ia32/disasm-ia32.cc (right):

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newc...
src/ia32/disasm-ia32.cc:410: AppendToBuffer("[%s*%d+0x%x]",
On 2014/03/04 13:43:35, titzer wrote:
> Here too!

Done.

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newc...
src/ia32/disasm-ia32.cc:440: AppendToBuffer("[%s+0x%x]",
(this->*register_name)(rm), disp);
On 2014/03/04 13:43:35, titzer wrote:
> Here too!

Done.

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newc...
src/ia32/disasm-ia32.cc:442: AppendToBuffer("[%s+%s*%d+0x%x]",
On 2014/03/04 13:43:35, titzer wrote:
> Here too!

Done.

https://codereview.chromium.org/176993004/diff/1/src/ia32/disasm-ia32.cc#newc...
src/ia32/disasm-ia32.cc:457: disp < 0 ? -disp : disp);
On 2014/03/04 13:43:35, titzer wrote:
> I think you want a subroutine for adding the displacement?
> 
> And x64! :/

Done for x64. No subroutine though, I think that's less readable.

Expand Messages | Collapse Messages