Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4379)

Unified Diff: android_webview/browser/test/rendering_test.cc

Issue 1769913003: sync compositor: Add output_surface_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix nit in test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/test/rendering_test.cc
diff --git a/android_webview/browser/test/rendering_test.cc b/android_webview/browser/test/rendering_test.cc
index 4f00a205ede7533a4011799b0999324a928211d0..e51f3aa92fe5e482e679495c1de87958336bdb4b 100644
--- a/android_webview/browser/test/rendering_test.cc
+++ b/android_webview/browser/test/rendering_test.cc
@@ -67,8 +67,7 @@ void RenderingTest::QuitMessageLoop() {
message_loop_->QuitWhenIdle();
}
-void RenderingTest::SetCompositorFrame() {
- DCHECK(compositor_.get());
+scoped_ptr<cc::CompositorFrame> RenderingTest::ConstructEmptyFrame() {
scoped_ptr<cc::CompositorFrame> compositor_frame(new cc::CompositorFrame);
scoped_ptr<cc::DelegatedFrameData> frame(new cc::DelegatedFrameData);
scoped_ptr<cc::RenderPass> root_pass(cc::RenderPass::Create());
@@ -77,11 +76,12 @@ void RenderingTest::SetCompositorFrame() {
gfx::Transform());
frame->render_pass_list.push_back(std::move(root_pass));
compositor_frame->delegated_frame_data = std::move(frame);
- compositor_->SetHardwareFrame(std::move(compositor_frame));
+ return compositor_frame;
}
void RenderingTest::WillOnDraw() {
- SetCompositorFrame();
+ DCHECK(compositor_);
+ compositor_->SetHardwareFrame(0u, ConstructEmptyFrame());
}
bool RenderingTest::RequestDrawGL(bool wait_for_completion) {
@@ -103,7 +103,8 @@ void RenderingTest::OnNewPicture() {
}
void RenderingTest::PostInvalidate() {
- window_->PostInvalidate();
+ if (window_)
+ window_->PostInvalidate();
}
void RenderingTest::DetachFunctorFromView() {

Powered by Google App Engine
This is Rietveld 408576698