Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1769903002: Move preferred stylesheet logic into StyleEngine. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
dstockwell, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, rwlbuis, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move preferred stylesheet logic into StyleEngine. To understand the code better: We don't support selecting alternate stylesheets in Blink, although the API for Document.selectedStylesheetSet is present. The way it works, is that the effective selected stylesheet set is either empty or the preferred set. Setting selectedStylesheetSet has no effect. This CL should not impose any functional changes, but a resolverChanged with no effect has been removed. The next step for async active stylesheet update is to move the setting of the preferred set name to where the the dom mutations happen as the order of mutations is what defines which stylesheet title has precedence. BUG=567021 Committed: https://crrev.com/bffd0dd4e962fb31897082a9b9e34e5bb1a7f331 Cr-Commit-Position: refs/heads/master@{#379762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCandidate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769903002/1
4 years, 9 months ago (2016-03-07 13:37:54 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 15:02:19 UTC) #4
rune
4 years, 9 months ago (2016-03-07 19:22:43 UTC) #6
esprehn
lgtm
4 years, 9 months ago (2016-03-08 05:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769903002/1
4 years, 9 months ago (2016-03-08 05:57:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 06:05:32 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:07:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bffd0dd4e962fb31897082a9b9e34e5bb1a7f331
Cr-Commit-Position: refs/heads/master@{#379762}

Powered by Google App Engine
This is Rietveld 408576698