Pipe a bit down to the InstantExtended new tab page javascript API for whether or not the app launc…

Pipe a bit down to the InstantExtended new tab page javascript API for whether or not the app launcher is enabled.

BUG=252867
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208596

[David Black, 2013-06-25 19:01:48]

Ready for review

[Peter Kasting, 2013-06-25 19:10:06]

When specifying multiple reviewers, say what you want each to review.

I assume I'm reviewing at least prepopulated_engines.json, which actually looks
like a local change from your checkout that you didn't intend to include in this
patch.

[David Black, 2013-06-25 19:25:36]

Ah, didn't realize Jered had owners over everything except render_messages.h. 
Removing pkasting and adding jschuh for render_messages.

(And sorry about the unintentional diff - I've reverted it.)

[David Black, 2013-06-25 19:28:35]

jschuh -> tsepez as jschuh is OOO.

[Tom Sepez, 2013-06-25 19:35:46]

Messages LGTM.

[Jered, 2013-06-25 20:34:35]

https://codereview.chromium.org/17699006/diff/5002/chrome/renderer/searchbox/...
File chrome/renderer/searchbox/searchbox_extension.cc (right):

https://codereview.chromium.org/17699006/diff/5002/chrome/renderer/searchbox/...
chrome/renderer/searchbox/searchbox_extension.cc:575: // Gets the font size of
the text in the omnibox.
Update comment.

[David Black, 2013-06-25 21:33:06]

https://codereview.chromium.org/17699006/diff/5002/chrome/renderer/searchbox/...
File chrome/renderer/searchbox/searchbox_extension.cc (right):

https://codereview.chromium.org/17699006/diff/5002/chrome/renderer/searchbox/...
chrome/renderer/searchbox/searchbox_extension.cc:575: // Gets the font size of
the text in the omnibox.
On 2013/06/25 20:34:35, Jered wrote:
> Update comment.

Done.

[Jered, 2013-06-25 22:12:22]

lgtm

One question.

https://codereview.chromium.org/17699006/diff/22001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_page.cc (right):

https://codereview.chromium.org/17699006/diff/22001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_page.cc:62:
sender()->SetPromoInformation(apps::IsAppLauncherEnabled());
This seems to be set based on a pref. But it looks like that pref is obsolete or
something. Do you want to deal with updating it when that pref changes?

[David Black, 2013-06-25 22:40:42]

https://codereview.chromium.org/17699006/diff/22001/chrome/browser/ui/search/...
File chrome/browser/ui/search/instant_page.cc (right):

https://codereview.chromium.org/17699006/diff/22001/chrome/browser/ui/search/...
chrome/browser/ui/search/instant_page.cc:62:
sender()->SetPromoInformation(apps::IsAppLauncherEnabled());
On 2013/06/25 22:12:23, Jered wrote:
> This seems to be set based on a pref. But it looks like that pref is obsolete
or
> something. Do you want to deal with updating it when that pref changes?

Eh?  Where are you seeing that it's obsolete?  IsAppLauncherEnabled checks the
pref prefs::kAppLauncherHasBeenEnabled, which is set here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/....

kAppLauncherIsEnabled seems to be obsolete - perhaps that's what you were
thinking of?

[commit-bot: I haz the power, 2013-06-25 22:41:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcblack@chromium.org/17699006/22001

[commit-bot: I haz the power, 2013-06-26 02:18:06]

Change committed as 208596