Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1769863003: Reorganize/rewrite the Mojom IDL intro. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reorganize/rewrite the Mojom IDL intro. I copied the old intro/outline to mojom_lang/mojom_lang.md (to reorganize later -- it should be reference-ish in nature). And I made intro/mojom_idl.md a briefer (and less formal) overview of (some of) the more important points about Mojom IDL. (Still left to write for intro/mojom_idl.md: stuff about consts and annotations.) R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c7f9e258b4eaa5f71908400e9630777db52afd03

Patch Set 1 #

Total comments: 1

Patch Set 2 : clarifications #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -198 lines) Patch
M docs/intro/mojom_idl.md View 1 2 chunks +234 lines, -198 lines 0 comments Download
A + docs/mojom_lang/mojom_lang.md View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-07 22:50:47 UTC) #1
vardhan
lgtm w/ clarification you have some common text between the two files, which seems like ...
4 years, 9 months ago (2016-03-08 00:41:24 UTC) #2
viettrungluu
Thanks. On 2016/03/08 00:41:24, vardhan wrote: > lgtm w/ clarification > > you have some ...
4 years, 9 months ago (2016-03-08 16:00:13 UTC) #3
viettrungluu
4 years, 9 months ago (2016-03-08 16:00:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c7f9e258b4eaa5f71908400e9630777db52afd03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698