Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1769863002: Reland of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1768963002/ ) Reason for revert: Fix landed in head. Original issue's description: > Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1774463002/ ) > > Reason for revert: > [Sheriff] Problem is not fixed: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8799 > > Original issue's description: > > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > > > This is a reland of https://codereview.chromium.org/1762203002/ > > > > R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org > > BUG= > > > > Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 > > Cr-Commit-Position: refs/heads/master@{#34519} > > TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/701e520b2bea1b70073e48959d97ee32a89cc73c Cr-Commit-Position: refs/heads/master@{#34523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
A test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +90 lines, -0 lines 0 comments Download
A test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +311 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Reland of [wasm] Add a JavaScript utility to make it easier to build WASM ...
4 years, 9 months ago (2016-03-07 10:01:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769863002/1
4 years, 9 months ago (2016-03-07 10:01:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 10:01:29 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 10:03:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/701e520b2bea1b70073e48959d97ee32a89cc73c
Cr-Commit-Position: refs/heads/master@{#34523}

Powered by Google App Engine
This is Rietveld 408576698