Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1769843002: Added tests for preferred sheet insertion order. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
dstockwell, esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added tests for preferred sheet insertion order. Which stylesheet wins setting the preferred stylesheet set based on the title attribute depends on the insertion order, and not the tree order, since it's done as part of adding a stylesheet[1], as part of creating a stylesheet[2], which is done on closing a style element, on inserting or removing the style element [3]. Added two tests to make sure this is still true after active stylesheet update has been made async. [1] https://drafts.csswg.org/cssom/#add-a-css-style-sheet [2] https://drafts.csswg.org/cssom/#create-a-css-style-sheet [3] https://html.spec.whatwg.org/#update-a-style-block BUG=567021 Committed: https://crrev.com/861066b09b34f5644e622d195ff2f4609502c364 Cr-Commit-Position: refs/heads/master@{#379760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/preferred-stylesheet-order.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/preferred-stylesheet-order-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/preferred-stylesheet-reversed-order.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/preferred-stylesheet-reversed-order-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769843002/1
4 years, 9 months ago (2016-03-07 09:51:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 10:57:33 UTC) #4
rune
4 years, 9 months ago (2016-03-07 19:22:11 UTC) #6
esprehn
Blech, such an awful feature. lgtm
4 years, 9 months ago (2016-03-08 05:58:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769843002/1
4 years, 9 months ago (2016-03-08 05:58:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 06:03:33 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 06:04:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/861066b09b34f5644e622d195ff2f4609502c364
Cr-Commit-Position: refs/heads/master@{#379760}

Powered by Google App Engine
This is Rietveld 408576698