Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: media/base/mime_util_unittest.cc

Issue 1769833003: Consolidate MPEG*_AAC_* MimeUtil::Codec enum values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment for 544268 and add comments to MP4 codecs expressions. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/mime_util_internal.cc ('K') | « media/base/mime_util_internal.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_unittest.cc
diff --git a/media/base/mime_util_unittest.cc b/media/base/mime_util_unittest.cc
index ca1f393723567ca8a4dc7fdd08db2b4c05892525..da9877da533d938eb95c40adb154a0bb76b1dba3 100644
--- a/media/base/mime_util_unittest.cc
+++ b/media/base/mime_util_unittest.cc
@@ -253,9 +253,7 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
case MimeUtil::INVALID_CODEC:
case MimeUtil::AC3:
case MimeUtil::EAC3:
- case MimeUtil::MPEG2_AAC_LC:
- case MimeUtil::MPEG2_AAC_MAIN:
- case MimeUtil::MPEG2_AAC_SSR:
+ case MimeUtil::MPEG2_AAC:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
break;
@@ -263,9 +261,7 @@ TEST(IsCodecSupportedOnPlatformTest, EncryptedCodecBehavior) {
// These codecs are always available with platform decoder support.
case MimeUtil::PCM:
case MimeUtil::MP3:
- case MimeUtil::MPEG4_AAC_LC:
- case MimeUtil::MPEG4_AAC_SBR_v1:
- case MimeUtil::MPEG4_AAC_SBR_PS_v2:
+ case MimeUtil::MPEG4_AAC:
case MimeUtil::VORBIS:
case MimeUtil::H264:
EXPECT_TRUE(result);
@@ -311,9 +307,7 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
case MimeUtil::INVALID_CODEC:
case MimeUtil::AC3:
case MimeUtil::EAC3:
- case MimeUtil::MPEG2_AAC_LC:
- case MimeUtil::MPEG2_AAC_MAIN:
- case MimeUtil::MPEG2_AAC_SSR:
+ case MimeUtil::MPEG2_AAC:
case MimeUtil::THEORA:
EXPECT_FALSE(result);
break;
@@ -321,9 +315,7 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithAndroidPipeline) {
// These codecs are always available via MediaPlayer.
case MimeUtil::PCM:
case MimeUtil::MP3:
- case MimeUtil::MPEG4_AAC_LC:
- case MimeUtil::MPEG4_AAC_SBR_v1:
- case MimeUtil::MPEG4_AAC_SBR_PS_v2:
+ case MimeUtil::MPEG4_AAC:
case MimeUtil::VORBIS:
case MimeUtil::H264:
case MimeUtil::VP8:
@@ -371,13 +363,9 @@ TEST(IsCodecSupportedOnPlatformTest, ClearCodecBehaviorWithUnifiedPipeline) {
// These codecs are always supported with the unified pipeline.
case MimeUtil::PCM:
- case MimeUtil::MPEG2_AAC_LC:
- case MimeUtil::MPEG2_AAC_MAIN:
- case MimeUtil::MPEG2_AAC_SSR:
+ case MimeUtil::MPEG2_AAC:
case MimeUtil::MP3:
- case MimeUtil::MPEG4_AAC_LC:
- case MimeUtil::MPEG4_AAC_SBR_v1:
- case MimeUtil::MPEG4_AAC_SBR_PS_v2:
+ case MimeUtil::MPEG4_AAC:
case MimeUtil::OPUS:
case MimeUtil::VORBIS:
case MimeUtil::VP8:
« media/base/mime_util_internal.cc ('K') | « media/base/mime_util_internal.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698