Remove deprecated declarations

Remove deprecated declarations


Remove deprecated declarations

BUG=pdfium:356
R=jochen@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/14e20b124744c3342d3ff0a288788e991087718b

[Jim Wang, 2016-03-07 08:34:06]

jinming_wang@foxitsoftware.com changed reviewers:
+ jochen@chromium.org, jun_fang@foxitsoftware.com, tsepez@chromium.org

[Jim Wang, 2016-03-07 08:34:06]

Hello Tom and Jochen, Please help to review this CL, thanks.

[jochen (gone - plz use gerrit), 2016-03-07 12:11:51]

lgtm

[Jim Wang, 2016-03-07 14:58:12]

Description was changed from

==========
Remove deprecated declarations


Remove deprecated declarations

BUG=pdfium:356
==========

to

==========
Remove deprecated declarations


Remove deprecated declarations

BUG=pdfium:356
R=jochen@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/14e20b124744c3342d3ff0a288788e991087...
==========

[Jim Wang, 2016-03-07 14:58:16]

Committed patchset #1 (id:1) manually as
14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).

[dsinclair, 2016-03-07 15:37:55]

On 2016/03/07 14:58:16, Jim Wang wrote:
> Committed patchset #1 (id:1) manually as
> 14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).

Looks like this broke the linux_xfa waterfall bot. 
https://build.chromium.org/p/client.pdfium/builders/linux_xfa/builds/606/step...

FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/xfa/src/fxjse/src/xfa.class.o.d -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS
-DCR_CLANG_REVISION=261368-1 -DFT2_BUILD_LIBRARY -D_DEBUG -D_GLIBCXX_DEBUG=1
-I../.. -I../../third_party/freetype/include
-I../../third_party/freetype/include/freetype -I../../v8 -I../../v8/include
-I../../v8/include -Wall -Werror -W -Wno-missing-field-initializers
-Wno-sign-compare -Wno-unused-parameter -pthread -fno-exceptions
-fvisibility=hidden -Wno-sign-compare -g -O0 -fdata-sections -ffunction-sections
-std=c++11 -fno-rtti  -c ../../xfa/src/fxjse/src/class.cpp -o
obj/xfa/src/fxjse/src/xfa.class.o
../../xfa/src/fxjse/src/class.cpp:36:5: error: ignoring return value of function
declared with warn_unused_result attribute [-Werror,-Wunused-result]
    hGlobalObject->DefineOwnProperty(
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[Jim Wang, 2016-03-07 16:18:07]

Description was changed from

==========
Remove deprecated declarations


Remove deprecated declarations

BUG=pdfium:356
R=jochen@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/14e20b124744c3342d3ff0a288788e991087...
==========

to

==========
Remove deprecated declarations


Remove deprecated declarations

BUG=pdfium:356
R=jochen@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/14e20b124744c3342d3ff0a288788e991087...
==========

[Jim Wang, 2016-03-07 16:25:33]

On 2016/03/07 15:37:55, dsinclair wrote:
> On 2016/03/07 14:58:16, Jim Wang wrote:
> > Committed patchset #1 (id:1) manually as
> > 14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).
> 
> Looks like this broke the linux_xfa waterfall bot. 
>
https://build.chromium.org/p/client.pdfium/builders/linux_xfa/builds/606/step...
> 
> FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/xfa/src/fxjse/src/xfa.class.o.d -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS
> -DCR_CLANG_REVISION=261368-1 -DFT2_BUILD_LIBRARY -D_DEBUG -D_GLIBCXX_DEBUG=1
> -I../.. -I../../third_party/freetype/include
> -I../../third_party/freetype/include/freetype -I../../v8 -I../../v8/include
> -I../../v8/include -Wall -Werror -W -Wno-missing-field-initializers
> -Wno-sign-compare -Wno-unused-parameter -pthread -fno-exceptions
> -fvisibility=hidden -Wno-sign-compare -g -O0 -fdata-sections
-ffunction-sections
> -std=c++11 -fno-rtti  -c ../../xfa/src/fxjse/src/class.cpp -o
> obj/xfa/src/fxjse/src/xfa.class.o
> ../../xfa/src/fxjse/src/class.cpp:36:5: error: ignoring return value of
function
> declared with warn_unused_result attribute [-Werror,-Wunused-result]
>     hGlobalObject->DefineOwnProperty(
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.

Patch set 2 has been uploaded to fix this issue.

[dsinclair, 2016-03-07 16:27:01]

On 2016/03/07 16:25:33, Jim Wang wrote:
> On 2016/03/07 15:37:55, dsinclair wrote:
> > On 2016/03/07 14:58:16, Jim Wang wrote:
> > > Committed patchset #1 (id:1) manually as
> > > 14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).
> > 
> > Looks like this broke the linux_xfa waterfall bot. 
> >
>
https://build.chromium.org/p/client.pdfium/builders/linux_xfa/builds/606/step...
> > 
> > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > obj/xfa/src/fxjse/src/xfa.class.o.d -DPDF_ENABLE_XFA
-DV8_DEPRECATION_WARNINGS
> > -DCR_CLANG_REVISION=261368-1 -DFT2_BUILD_LIBRARY -D_DEBUG -D_GLIBCXX_DEBUG=1
> > -I../.. -I../../third_party/freetype/include
> > -I../../third_party/freetype/include/freetype -I../../v8 -I../../v8/include
> > -I../../v8/include -Wall -Werror -W -Wno-missing-field-initializers
> > -Wno-sign-compare -Wno-unused-parameter -pthread -fno-exceptions
> > -fvisibility=hidden -Wno-sign-compare -g -O0 -fdata-sections
> -ffunction-sections
> > -std=c++11 -fno-rtti  -c ../../xfa/src/fxjse/src/class.cpp -o
> > obj/xfa/src/fxjse/src/xfa.class.o
> > ../../xfa/src/fxjse/src/class.cpp:36:5: error: ignoring return value of
> function
> > declared with warn_unused_result attribute [-Werror,-Wunused-result]
> >     hGlobalObject->DefineOwnProperty(
> >     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> 
> Patch set 2 has been uploaded to fix this issue.


Can you upload the fix as a new CL as this one has already landed?

[dsinclair, 2016-03-07 19:39:47]

On 2016/03/07 16:27:01, dsinclair wrote:
> On 2016/03/07 16:25:33, Jim Wang wrote:
> > On 2016/03/07 15:37:55, dsinclair wrote:
> > > On 2016/03/07 14:58:16, Jim Wang wrote:
> > > > Committed patchset #1 (id:1) manually as
> > > > 14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).
> > > 
> > > Looks like this broke the linux_xfa waterfall bot. 
> > >
> >
>
https://build.chromium.org/p/client.pdfium/builders/linux_xfa/builds/606/step...
> > > 
> > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > > obj/xfa/src/fxjse/src/xfa.class.o.d -DPDF_ENABLE_XFA
> -DV8_DEPRECATION_WARNINGS
> > > -DCR_CLANG_REVISION=261368-1 -DFT2_BUILD_LIBRARY -D_DEBUG
-D_GLIBCXX_DEBUG=1
> > > -I../.. -I../../third_party/freetype/include
> > > -I../../third_party/freetype/include/freetype -I../../v8
-I../../v8/include
> > > -I../../v8/include -Wall -Werror -W -Wno-missing-field-initializers
> > > -Wno-sign-compare -Wno-unused-parameter -pthread -fno-exceptions
> > > -fvisibility=hidden -Wno-sign-compare -g -O0 -fdata-sections
> > -ffunction-sections
> > > -std=c++11 -fno-rtti  -c ../../xfa/src/fxjse/src/class.cpp -o
> > > obj/xfa/src/fxjse/src/xfa.class.o
> > > ../../xfa/src/fxjse/src/class.cpp:36:5: error: ignoring return value of
> > function
> > > declared with warn_unused_result attribute [-Werror,-Wunused-result]
> > >     hGlobalObject->DefineOwnProperty(
> > >     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > 1 error generated.
> > 
> > Patch set 2 has been uploaded to fix this issue.
> 
> 
> Can you upload the fix as a new CL as this one has already landed?


I pulled this into https://codereview.chromium.org/1770103002/ and landed.
Thanks for the fix.

[Jim Wang, 2016-03-07 23:42:26]

On 2016/03/07 19:39:47, dsinclair wrote:
> On 2016/03/07 16:27:01, dsinclair wrote:
> > On 2016/03/07 16:25:33, Jim Wang wrote:
> > > On 2016/03/07 15:37:55, dsinclair wrote:
> > > > On 2016/03/07 14:58:16, Jim Wang wrote:
> > > > > Committed patchset #1 (id:1) manually as
> > > > > 14e20b124744c3342d3ff0a288788e991087718b (presubmit successful).
> > > > 
> > > > Looks like this broke the linux_xfa waterfall bot. 
> > > >
> > >
> >
>
https://build.chromium.org/p/client.pdfium/builders/linux_xfa/builds/606/step...
> > > > 
> > > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD
-MF
> > > > obj/xfa/src/fxjse/src/xfa.class.o.d -DPDF_ENABLE_XFA
> > -DV8_DEPRECATION_WARNINGS
> > > > -DCR_CLANG_REVISION=261368-1 -DFT2_BUILD_LIBRARY -D_DEBUG
> -D_GLIBCXX_DEBUG=1
> > > > -I../.. -I../../third_party/freetype/include
> > > > -I../../third_party/freetype/include/freetype -I../../v8
> -I../../v8/include
> > > > -I../../v8/include -Wall -Werror -W -Wno-missing-field-initializers
> > > > -Wno-sign-compare -Wno-unused-parameter -pthread -fno-exceptions
> > > > -fvisibility=hidden -Wno-sign-compare -g -O0 -fdata-sections
> > > -ffunction-sections
> > > > -std=c++11 -fno-rtti  -c ../../xfa/src/fxjse/src/class.cpp -o
> > > > obj/xfa/src/fxjse/src/xfa.class.o
> > > > ../../xfa/src/fxjse/src/class.cpp:36:5: error: ignoring return value of
> > > function
> > > > declared with warn_unused_result attribute [-Werror,-Wunused-result]
> > > >     hGlobalObject->DefineOwnProperty(
> > > >     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > 1 error generated.
> > > 
> > > Patch set 2 has been uploaded to fix this issue.
> > 
> > 
> > Can you upload the fix as a new CL as this one has already landed?
> 
> 
> I pulled this into https://codereview.chromium.org/1770103002/ and landed.
> Thanks for the fix.

Thanks for the help, dsinclair, I didn't notice that a new Cl should land.