Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1769743002: Fix media memory usage reporting after a pipeline suspend. (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix media memory usage reporting after a pipeline suspend. This resolves a couple issues: - Stops the memory usage reporting timer when hidden. - Clears the audio/video memory PipelineStatistics entries upon PipelineImpl completing its suspend. BUG=592186 TEST=new unittest, manually verify timer stops in bg. Committed: https://crrev.com/3a7d38f42891b83a503228607435586dc1f55465 Cr-Commit-Position: refs/heads/master@{#379644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M media/base/pipeline_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/pipeline_impl_unittest.cc View 3 chunks +16 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
DaleCurtis
4 years, 9 months ago (2016-03-05 02:43:40 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-07 19:37:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1769743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1769743002/1
4 years, 9 months ago (2016-03-07 19:44:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-07 21:17:23 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-07 21:18:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a7d38f42891b83a503228607435586dc1f55465
Cr-Commit-Position: refs/heads/master@{#379644}

Powered by Google App Engine
This is Rietveld 408576698